Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make google_iam_workload_identity_pool_provider.oidc updatable #3350

Conversation

modular-magician
Copy link
Collaborator

Context: b/190760650

Currently, attempting to update fields within oidc gives the error:

googleapi: Error 400: A FieldMask with at least one path must be specified.

There were two problems with updating this field are:

  1. oidc was set to input: true while the child fields were not. oidc.allowed_audiences and oidc.issuer_uri were not ForceNew but also not included in the field mask. This lead to the above error
  2. ForceNew doesn't work for this resource unless the identity fields are changing. Deleting this resource just sets the status to inactive and when the provider goes to recreate it causes a 409 already existing

To remedy this, I removed input: true on the appropriate fields and added oidc.allowed_audiences and oidc.issuer_uri to the update mask. Also added a test step to use this scenario.

Release Note Template for Downstream PRs (will be copied)

iam: fixed an issue in `google_iam_workload_identity_pool_provider` where `aws` and `oidc` were not updatable.

Derived from GoogleCloudPlatform/magic-modules#4879

@modular-magician modular-magician merged commit 1080c3b into hashicorp:master Jun 16, 2021
@modular-magician modular-magician deleted the downstream-pr-dd93a0c1c9a33f3f7c356dc8e5d981e6dc155c01 branch November 16, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant