Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made nic_type default to a string (and expand as a string) #3060

Conversation

modular-magician
Copy link
Collaborator

Related to GoogleCloudPlatform/terraform-validator#195

Nic type expansion was causing a panic in terraform validator because a nil value couldn't be converted to an interface. We don't actually need to expand nic_type, because it will be a string.

When I generate tgc & the provider locally and force tfv to use the local versions with replace directives, tfv is able to read plan json that contains null values for nic_type without any issues.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#4598

@ghost ghost added the size/xs label Mar 16, 2021
@modular-magician modular-magician merged commit 66e5ed1 into hashicorp:master Mar 16, 2021
@modular-magician modular-magician deleted the downstream-pr-76a35a8cb0d37e1d6fc412dd562ad3c2b441bc11 branch November 16, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant