Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform 7459 redis AUTH support in beta #2570

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Terraform 7459 redis AUTH support in beta #2570

merged 1 commit into from
Oct 9, 2020

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#7459.

Adds support for redis AUTH in beta.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

redis: Added `auth_enabled` field to `google_redis_instance` (google-beta provider only)

Derived from GoogleCloudPlatform/magic-modules#4079

@modular-magician @rileykarson
Terraform 7459 redis AUTH support in beta (hashicorp#4079)
6be05fa 
* Added authEnabled to redis instance

* Added tests for auth_enabled in beta

* Updated redis instance data source docs to make current best practices

Specifically: not duplicating the list of attributes.

* Added test of disabling auth_enabled as well

* Remove "from its name" from redis instance data source docs

Co-authored-by: Riley Karson <[email protected]>

Co-authored-by: Riley Karson <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 7e21069 into hashicorp:master Oct 9, 2020
@modular-magician modular-magician deleted the downstream-pr-bbf8f32e1a83a30a2bb3fd0b4e0f144a37350640 branch November 16, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for auth_enabled in google_redis_instance
1 participant
@modular-magician