Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[resource_container_cluster] - Add self-link property #2457

Merged
merged 1 commit into from
Sep 3, 2020
Merged

[resource_container_cluster] - Add self-link property #2457

merged 1 commit into from
Sep 3, 2020

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Sep 3, 2020 •
edited by megan07
Loading

Add self link property to resource_container_cluster.

Resolves 7120

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: Added `self_link` to google_container_cluster

Derived from GoogleCloudPlatform/magic-modules#3942

@modular-magician
[resource_container_cluster] - Add self-link property (hashicorp#3942)
918f93b 
* [resource_container_cluster] - Add self-link property

* add comma to property definition

* Added documentation reference

* extend existing test with output property validation

Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/xs label Sep 3, 2020
@modular-magician modular-magician merged commit 5c20122 into hashicorp:master Sep 3, 2020
@modular-magician modular-magician deleted the downstream-pr-7f03e15d6fc80fff0c9b131439ff8d74d51d732f branch November 16, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add self_link to google_container_cluster
1 participant
@modular-magician