Add the google_dataflow_flex_template_job resource
#2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cameron Thornton <[email protected]> Co-authored-by: eric-hole <[email protected]> Signed-off-by: Modular Magician <[email protected]>
ghost
added
modular-magician
deleted the
downstream-pr-9d0284981f2aab9516cbf37a3660dd84bd6e2295
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes GoogleCloudPlatform/magic-modules#3520, fixes hashicorp/terraform-provider-google#6656
I squashed the original PR into a single commit and overlayed on top to keep the commit count manageable. I got this to a passing test, but spent most of my time getting that inline template right- the example linked from the docs was broken and there was some manual work with
gcloudinvolved with getting a properly formatted template. I don't believe we need to document that part- it's already covered by Using Flex Templates.I reviewed the original PR over a fairly long period of time and lost context several times throughout. A fresh look at most of the changes would be appreciated- most aren't mine, I made targeted changes to get this to a passing state.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3772