Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to clarify scheduler docs on pubsub #1572

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Try to clarify scheduler docs on pubsub #1572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions google-beta/resource_cloud_scheduler_job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,10 @@ a message to the provided topic`,
Type: schema.TypeString,
Required: true,
ForceNew: true,
Description: `The name of the Cloud Pub/Sub topic to which messages will be published when a job is delivered.
The topic name must be in the same format as required by PubSub's PublishRequest.name,
for example projects/PROJECT_ID/topics/TOPIC_ID.`,
Description: `The full resource name for the Cloud Pub/Sub topic to which
messages will be published when a job is delivered. ~>**NOTE**:
The topic name must be in the same format as required by PubSub's
PublishRequest.name, e.g. 'projects/my-project/topics/my-topic'.`,
},
"attributes": {
Type: schema.TypeMap,
Expand Down
1 change: 1 addition & 0 deletions google-beta/resource_cloud_scheduler_job_generated_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ resource "google_cloud_scheduler_job" "job" {
schedule = "*/2 * * * *"

pubsub_target {
# topic.id is the topic's full resource name.
topic_name = google_pubsub_topic.topic.id
data = base64encode("test")
}
Expand Down
8 changes: 5 additions & 3 deletions website/docs/r/cloud_scheduler_job.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ resource "google_cloud_scheduler_job" "job" {
schedule = "*/2 * * * *"

pubsub_target {
# topic.id is the topic's full resource name.
topic_name = google_pubsub_topic.topic.id
data = base64encode("test")
}
Expand Down Expand Up @@ -261,9 +262,10 @@ The `pubsub_target` block supports:

* `topic_name` -
(Required)
The name of the Cloud Pub/Sub topic to which messages will be published when a job is delivered.
The topic name must be in the same format as required by PubSub's PublishRequest.name,
for example projects/PROJECT_ID/topics/TOPIC_ID.
The full resource name for the Cloud Pub/Sub topic to which
messages will be published when a job is delivered. ~>**NOTE**:
The topic name must be in the same format as required by PubSub's
PublishRequest.name, e.g. `projects/my-project/topics/my-topic`.

* `data` -
(Optional)
Expand Down