Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_automation_schedule - import time/tzdata to embed timezone information #20765

Merged
merged 3 commits into from
Mar 7, 2023
Merged

azurerm_automation_schedule - import time/tzdata to embed timezone information #20765

merged 3 commits into from
Mar 7, 2023

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Mar 3, 2023

whilst some platform/system does not provide full timezone information in the tzdata database, time.LoadLocation() will raise an error. this PR will cause the binary file size increase about <10kb by embeding the zip data of timezone into the built binary file.

reference golang/go#38017

resolves #20690.

tombuildsstuff
tombuildsstuff reviewed Mar 6, 2023
View reviewed changes
internal/services/automation/automation_schedule_resource.go Outdated
Comment on lines 10 to 11
// import time/tzdata to embed timezone information in the program
_ "time/tzdata"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we link to the github issue this is fixing so we don't unintentionally remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for you suggestion, comment added. 🎉

katbyte
katbyte approved these changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕙

@katbyte katbyte merged commit 2f07a92 into hashicorp:main Mar 7, 2023
@github-actions github-actions bot added this to the v3.47.0 milestone Mar 7, 2023
jackofallops pushed a commit to xiaxyi/terraform-provider-azurerm that referenced this pull request Mar 7, 2023
@wuxu92 @jackofallops
azurerm_automation_schedule - import time/tzdata to embed timezon…
d925785 
…e information (hashicorp#20765)
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff left review comments

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
service/automation size/XS
Projects
None yet
Milestone
v3.47.0
Development

Successfully merging this pull request may close these issues.

"unknown time zone <timezone>" on azurerm_automation_schedule
3 participants
@wuxu92 @tombuildsstuff @katbyte