New Resource:`azurerm_mobile_network_packet_core_control_plane`;New Datasource: `azurerm_mobile_network_packet_core_control_plane` #20730

ziyeqf · 2023-03-02T05:27:31Z

overall

order | name 
0     | azurerm_mobile_network                              ✅
1     | azurerm_mobile_network_site                         ✅
1     | azurerm_mobile_network_data_network                 ✅
1     | azurerm_mobile_network_service                      ✅
1     | azurerm_mobile_network_slice                        ✅
1     | azurerm_mobile_network_sim_group                    ✅
2     | azurerm_mobile_network_packet_core_control_plane    <- this one
2     | azurerm_mobile_network_sim_policy                   #20732
3     | azurerm_mobile_network_packet_core_data_plane       
4     | azurerm_mobile_network_attached_data_network        
5     | azurerm_mobile_network_sim

test

terraform-provider-azurerm ❯ TF_ACC=1 go test -v ./internal/services/mobilenetwork -run=TestAccMobileNetworkPacketCoreControlPlan -timeout=600m
=== RUN   TestAccMobileNetworkPacketCoreControlPlanDataSource_basic
=== PAUSE TestAccMobileNetworkPacketCoreControlPlanDataSource_basic
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_basic
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_basic
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withIneropSettings
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withIneropSettings
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withUeMTU
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withUeMTU
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_requiresImport
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_requiresImport
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_update
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_update
=== CONT  TestAccMobileNetworkPacketCoreControlPlanDataSource_basic
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withUeMTU
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_requiresImport
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_update
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_basic
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withIneropSettings
--- PASS: TestAccMobileNetworkPacketCoreControlPlanDataSource_basic (565.67s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withIneropSettings (644.19s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface (650.68s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withUeMTU (652.88s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_requiresImport (666.71s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_basic (678.05s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_update (784.06s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity (858.69s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mobilenetwork 859.875s

…atasource: `azurerm_mobile_network_packet_core_control_plane`

website/docs/r/mobile_network_packet_core_control_plane.html.markdown

ziyeqf · 2023-03-03T03:57:36Z

have limited the test region..

terraform-provider-azurerm ❯ TF_ACC=1 go test -v ./internal/services/mobilenetwork -run=TestAccMobileNetworkPacketCoreControlPlan -timeout=600m
=== RUN   TestAccMobileNetworkPacketCoreControlPlanDataSource_basic
=== PAUSE TestAccMobileNetworkPacketCoreControlPlanDataSource_basic
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_basic
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_basic
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withIneropSettings
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withIneropSettings
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withUeMTU
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withUeMTU
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_requiresImport
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_requiresImport
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_update
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_update
=== CONT  TestAccMobileNetworkPacketCoreControlPlanDataSource_basic
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withUeMTU
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_basic
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withIneropSettings
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_requiresImport
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_update
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity
--- PASS: TestAccMobileNetworkPacketCoreControlPlanDataSource_basic (576.30s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withIneropSettings (583.37s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface (584.61s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withUeMTU (588.17s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_basic (591.30s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_requiresImport (610.32s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_update (878.47s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity (897.50s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mobilenetwork 898.712s

website/docs/r/mobile_network_packet_core_control_plane.html.markdown

website/docs/d/mobile_network_packet_core_control_plane.html.markdown

internal/services/mobilenetwork/mobile_network_packet_core_control_plane_resource.go

ziyeqf · 2023-03-15T05:01:16Z

katbyte

LGTM ☎️

tombuildsstuff · 2023-03-21T10:37:56Z

@ziyeqf unfortunately we're going to need to revert this PR for now since there's some larger changes needed to make this shippable - I'll open a PR and then comment on this one to explain in more details

…e`;New Datasource: `azurerm_mobile_network_packet_core_control_plane` (#20730)" This reverts commit 1a3887b.

This reverts commit 5a13d1c.

tombuildsstuff

hi @ziyeqf

As mentioned in the last comment, unfortunately we're having to revert this PR in #21058 since it requires some larger schema changes. I've left comments inline for those, but if you're able to fix those up then we should be able to take another look.

Thanks!

internal/services/mobilenetwork/interfaceproperties.go

internal/services/mobilenetwork/mobile_network_packet_core_control_plane_data_source.go

internal/services/mobilenetwork/mobile_network_packet_core_control_plane_resource.go

tombuildsstuff · 2023-03-21T11:02:53Z

internal/services/mobilenetwork/mobile_network_packet_core_control_plane_resource.go

+	var outputList []PlatformConfigurationModel
+
+	output := PlatformConfigurationModel{
+		Type: string(input.Type),


(as above) we generally don't expose the type field, what's the value for doing so here?

it's used to indentify the type of platform, just a parameter pass to service..

AFAIK, the type of platform could not be told by the input of other parameters. AFAIK, the only way is to specify it manually.

internal/services/mobilenetwork/mobile_network_packet_core_control_plane_resource.go

reverting #20730

github-actions · 2023-04-23T02:12:59Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

New Resource:azurerm_mobile_network_packet_core_control_plane;New D…

e659256

…atasource: `azurerm_mobile_network_packet_core_control_plane`

github-actions bot added dependencies documentation service/mobile-network size/XL labels Mar 2, 2023

ziyeqf added 2 commits March 2, 2023 13:49

update doc

3dbf05b

terrafmt

f21e00d

katbyte requested changes Mar 3, 2023

View reviewed changes

website/docs/r/mobile_network_packet_core_control_plane.html.markdown Outdated Show resolved Hide resolved

github-actions bot added the waiting-response label Mar 3, 2023

rename property & limit test region

744e7ed

github-actions bot removed the waiting-response label Mar 3, 2023

ziyeqf requested a review from katbyte March 9, 2023 09:36

katbyte requested changes Mar 14, 2023

View reviewed changes

katbyte added the waiting-response label Mar 14, 2023

ziyeqf added 3 commits March 15, 2023 10:07

rename interop_settings to interop_json

d544279

Merge remote-tracking branch 'hashi/main' into tengzh/mn_pccp

721b291

refresh vendor

9d5a13d

github-actions bot removed the waiting-response label Mar 15, 2023

limit test region

60a0c4c

ziyeqf force-pushed the tengzh/mn_pccp branch from b191400 to 60a0c4c Compare March 15, 2023 03:08

ziyeqf requested a review from katbyte March 20, 2023 01:51

katbyte approved these changes Mar 20, 2023

View reviewed changes

katbyte merged commit 1a3887b into hashicorp:main Mar 20, 2023

github-actions bot added this to the v3.49.0 milestone Mar 20, 2023

katbyte added a commit that referenced this pull request Mar 20, 2023

Update CHANGELOG.mdCHANGELOG #20730

5a13d1c

tombuildsstuff mentioned this pull request Mar 21, 2023

New Resource: azurerm_mobile_network_packet_core_data_plane;New DataSource: azurerm_mobile_network_packet_core_data_plane #21053

Merged

tombuildsstuff added a commit that referenced this pull request Mar 21, 2023

Revert "New Resource:`azurerm_mobile_network_packet_core_control_plan…

37fb4e1

…e`;New Datasource: `azurerm_mobile_network_packet_core_control_plane` (#20730)" This reverts commit 1a3887b.

tombuildsstuff added a commit that referenced this pull request Mar 21, 2023

Revert "Update CHANGELOG.mdCHANGELOG #20730"

ef3efbb

This reverts commit 5a13d1c.

tombuildsstuff reviewed Mar 21, 2023

View reviewed changes

github-actions bot added the waiting-response label Mar 21, 2023

tombuildsstuff mentioned this pull request Mar 21, 2023

reverting #20730 #21058

Merged

tombuildsstuff added a commit that referenced this pull request Mar 21, 2023

Merge pull request #21058 from hashicorp/b/revert-20730

83576ec

reverting #20730

tombuildsstuff removed this from the v3.49.0 milestone Mar 21, 2023

github-actions bot removed the waiting-response label Mar 22, 2023

ziyeqf mentioned this pull request Mar 22, 2023

New Resource:azurerm_mobile_network_packet_core_control_plane;New Datasource: azurerm_mobile_network_packet_core_control_plane #21071

Merged

github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource:`azurerm_mobile_network_packet_core_control_plane`;New Datasource: `azurerm_mobile_network_packet_core_control_plane` #20730

New Resource:`azurerm_mobile_network_packet_core_control_plane`;New Datasource: `azurerm_mobile_network_packet_core_control_plane` #20730

ziyeqf commented Mar 2, 2023 •

edited

Loading

ziyeqf commented Mar 3, 2023 •

edited

Loading

ziyeqf commented Mar 15, 2023

katbyte left a comment

tombuildsstuff commented Mar 21, 2023

tombuildsstuff left a comment

tombuildsstuff Mar 21, 2023

ziyeqf Mar 22, 2023

ziyeqf Mar 22, 2023

github-actions bot commented Apr 23, 2023

New Resource:azurerm_mobile_network_packet_core_control_plane;New Datasource: azurerm_mobile_network_packet_core_control_plane #20730

New Resource:azurerm_mobile_network_packet_core_control_plane;New Datasource: azurerm_mobile_network_packet_core_control_plane #20730

Conversation

ziyeqf commented Mar 2, 2023 • edited Loading

overall

test

ziyeqf commented Mar 3, 2023 • edited Loading

ziyeqf commented Mar 15, 2023

katbyte left a comment

Choose a reason for hiding this comment

tombuildsstuff commented Mar 21, 2023

tombuildsstuff left a comment

Choose a reason for hiding this comment

tombuildsstuff Mar 21, 2023

Choose a reason for hiding this comment

ziyeqf Mar 22, 2023

Choose a reason for hiding this comment

ziyeqf Mar 22, 2023

Choose a reason for hiding this comment

github-actions bot commented Apr 23, 2023

New Resource:`azurerm_mobile_network_packet_core_control_plane`;New Datasource: `azurerm_mobile_network_packet_core_control_plane` #20730

New Resource:`azurerm_mobile_network_packet_core_control_plane`;New Datasource: `azurerm_mobile_network_packet_core_control_plane` #20730

ziyeqf commented Mar 2, 2023 •

edited

Loading

ziyeqf commented Mar 3, 2023 •

edited

Loading