-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Healthcareapi/workspace #15759
Healthcareapi/workspace #15759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @xiaxyi. This is off to a good start, I have several questions and suggestions though. Once those are addressed we can take another look at this.
internal/services/healthcare/healthcare_apis_workspace_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/healthcare/healthcare_apis_workspace_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/healthcare/healthcare_apis_workspace_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/healthcare/healthcare_apis_workspace_resource.go
Outdated
Show resolved
Hide resolved
@stephybun Thanks for the suggestions, updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor corrections on the docs and it looks like a couple of comments from my last review were not applied. Could you go through those again and also split the create and update methods. Thanks @xiaxyi!
internal/services/healthcare/healthcare_apis_workspace_data_source_test.go
Outdated
Show resolved
Hide resolved
Thanks @stephybun. updated the code and I renamed the file ad well. |
…tags for healthcare workspace resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you don't mind I added the docs for the data source which were missing and an update test for the resource and pushed those to your branch.
Tests are passing and this LGTM 🚀
Thanks again @xiaxyi!
This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Add new resource `healthcareapis2.0 workspace"
The Azure healthcare api2.0 is a set of managed API services based on open standards and frameworks that enable workflows to improve healthcare and offer scalable and secure healthcare solutions.
Below services are included:
acc test
docs: