Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcareapi/workspace #15759

Merged
merged 16 commits into from
Mar 16, 2022
Merged

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Mar 9, 2022

Add new resource `healthcareapis2.0 workspace"

The Azure healthcare api2.0 is a set of managed API services based on open standards and frameworks that enable workflows to improve healthcare and offer scalable and secure healthcare solutions.

Below services are included:
image

acc test

--- PASS: TestAccHealthCareWorkspaceDataSource_basic (318.74s)
--- PASS: TestAccHealthCareWorkspace_basic (365.45s)
--- PASS: TestAccHealthCareWorkspace_requiresImport (382.88s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/healthcare    383.539s

docs:

  1. Azure healthcare api
  2. Azure healthcare workspace

@stephybun stephybun self-assigned this Mar 14, 2022
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @xiaxyi. This is off to a good start, I have several questions and suggestions though. Once those are addressed we can take another look at this.

internal/services/healthcare/client/client.go Outdated Show resolved Hide resolved
internal/services/healthcare/registration.go Outdated Show resolved Hide resolved
internal/services/healthcare/registration.go Outdated Show resolved Hide resolved
test/testSubnetOrder/main.tf Outdated Show resolved Hide resolved
website/docs/r/healthcare_workspace.html.markdown Outdated Show resolved Hide resolved
website/docs/r/healthcare_workspace.html.markdown Outdated Show resolved Hide resolved
@xiaxyi
Copy link
Contributor Author

xiaxyi commented Mar 15, 2022

@stephybun Thanks for the suggestions, updated

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor corrections on the docs and it looks like a couple of comments from my last review were not applied. Could you go through those again and also split the create and update methods. Thanks @xiaxyi!

website/docs/r/healthcare_workspace.html.markdown Outdated Show resolved Hide resolved
website/docs/r/healthcare_workspace.html.markdown Outdated Show resolved Hide resolved
website/docs/r/healthcare_workspace.html.markdown Outdated Show resolved Hide resolved
website/docs/r/healthcare_workspace.html.markdown Outdated Show resolved Hide resolved
@xiaxyi
Copy link
Contributor Author

xiaxyi commented Mar 16, 2022

Thanks @stephybun. updated the code and I renamed the file ad well.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you don't mind I added the docs for the data source which were missing and an update test for the resource and pushed those to your branch.

image

Tests are passing and this LGTM 🚀

Thanks again @xiaxyi!

@stephybun stephybun merged commit 7ac8f89 into hashicorp:main Mar 16, 2022
@github-actions github-actions bot added this to the v3.0.0 milestone Mar 16, 2022
stephybun added a commit that referenced this pull request Mar 16, 2022
@github-actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2022
@xiaxyi xiaxyi deleted the healthcareapi/workspace branch August 14, 2022 00:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants