-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for identity_client_id
and certificate_information
in azurerm_api_management
#12262
Conversation
Hi kt, would you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed @yupwei68 - overall looks good and left some comments inline
Hi kt, I've updated the changes. Thanks for comments. Please continue reviewing. |
Hi kt, I've updated to the latest upstream changes. Please continue reviewing. |
Please continue reviewing. Tests have passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh i like this idea much better @yupwei68! thanks for that LGTM 🙌
This functionality has been released in v2.74.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fix: #12260
Previously api mgmt service doesn't support user assigned identity in
hostname_configuration
, which caused we need separate steps for applying a key vault certificate inhostname_configuration
. Now this could be solved.certificate
will return some basic certificate information (expiry
,subject
,thumbprint
) for every certificate.--- PASS: TestAccApiManagement_complete (2429.80s)
--- PASS: TestAccApiManagement_identityUserAssignedHostnameConfigurationsVersionedKeyVaultId (4682.85s)