Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for identity_client_id and certificate_information in azurerm_api_management #12262

Merged
merged 26 commits into from
Aug 27, 2021

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Jun 18, 2021

Fix: #12260

Previously api mgmt service doesn't support user assigned identity in hostname_configuration, which caused we need separate steps for applying a key vault certificate in hostname_configuration. Now this could be solved.

certificate will return some basic certificate information (expiry, subject, thumbprint) for every certificate.

--- PASS: TestAccApiManagement_complete (2429.80s)
--- PASS: TestAccApiManagement_identityUserAssignedHostnameConfigurationsVersionedKeyVaultId (4682.85s)

yupwei68 added 21 commits May 26, 2021 14:23
@github-actions github-actions bot added size/L and removed size/XL labels Jun 25, 2021
@yupwei68
Copy link
Contributor Author

yupwei68 commented Aug 2, 2021

Hi kt, would you review this?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed @yupwei68 - overall looks good and left some comments inline

website/docs/r/api_management.html.markdown Outdated Show resolved Hide resolved
website/docs/r/api_management.html.markdown Outdated Show resolved Hide resolved
@yupwei68
Copy link
Contributor Author

yupwei68 commented Aug 4, 2021

Hi kt, I've updated the changes. Thanks for comments. Please continue reviewing.

@yupwei68
Copy link
Contributor Author

Hi kt, I've updated to the latest upstream changes. Please continue reviewing.

@github-actions github-actions bot added size/XL and removed size/L labels Aug 24, 2021
@yupwei68 yupwei68 requested a review from katbyte August 24, 2021 07:29
@yupwei68
Copy link
Contributor Author

Please continue reviewing. Tests have passed.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh i like this idea much better @yupwei68! thanks for that LGTM 🙌

@katbyte katbyte added this to the v2.74.0 milestone Aug 27, 2021
@katbyte katbyte merged commit 24e0c9c into hashicorp:main Aug 27, 2021
katbyte added a commit that referenced this pull request Aug 27, 2021
@github-actions
Copy link

This functionality has been released in v2.74.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for UserAssigned Identity for hostname configuration in azurerm_api_management
2 participants