Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_iot_thing: Ensure attributes configurations use equals #7275

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 23, 2019

These changes are backwards compatible with Terraform 0.11.

Previous output from Terraform 0.12 acceptance testing:

--- FAIL: TestAccAWSIotThing_full (0.60s)
    testing.go:568: Step 0 error: config is invalid: Unsupported block type: Blocks of type "attributes" are not expected here. Did you mean to define argument "attributes"? If so, use the equals sign to assign it a value.

Output from Terraform 0.12 acceptance testing (additional fixes required upstream in Terraform Provider SDK):

--- FAIL: TestAccAWSIotThing_full (317.27s)
    testing.go:568: Step 0 error: After applying this step, the plan was not empty:

        DIFF:

        UPDATE: aws_iot_thing_type.test
          arn:                      "arn:aws:iot:us-west-2:187416307283:thingtype/tf_acc_type_zaw92zkc" => "arn:aws:iot:us-west-2:187416307283:thingtype/tf_acc_type_zaw92zkc"
          deprecated:               "false" => "false"
          id:                       "tf_acc_type_zaw92zkc" => "tf_acc_type_zaw92zkc"
          name:                     "tf_acc_type_zaw92zkc" => "tf_acc_type_zaw92zkc"
          properties.#:             "1" => ""
          properties.0.description: "" => ""

These changes are backwards compatible with Terraform 0.11.

Previous output from Terraform 0.12 acceptance testing:

```
--- FAIL: TestAccAWSIotThing_full (0.60s)
    testing.go:568: Step 0 error: config is invalid: Unsupported block type: Blocks of type "attributes" are not expected here. Did you mean to define argument "attributes"? If so, use the equals sign to assign it a value.
```

Output from Terraform 0.12 acceptance testing (additional fixes required upstream in Terraform Provider SDK):

```
--- FAIL: TestAccAWSIotThing_full (317.27s)
    testing.go:568: Step 0 error: After applying this step, the plan was not empty:

        DIFF:

        UPDATE: aws_iot_thing_type.test
          arn:                      "arn:aws:iot:us-west-2:187416307283:thingtype/tf_acc_type_zaw92zkc" => "arn:aws:iot:us-west-2:187416307283:thingtype/tf_acc_type_zaw92zkc"
          deprecated:               "false" => "false"
          id:                       "tf_acc_type_zaw92zkc" => "tf_acc_type_zaw92zkc"
          name:                     "tf_acc_type_zaw92zkc" => "tf_acc_type_zaw92zkc"
          properties.#:             "1" => ""
          properties.0.description: "" => ""
```
@bflad bflad added this to the v2.0.0 milestone Jan 23, 2019
@bflad bflad requested a review from a team January 23, 2019 19:21
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/iot Issues and PRs that pertain to the iot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jan 23, 2019
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit 6e67202 into master Jan 23, 2019
@bflad bflad deleted the td-aws_iot_thing-0.12-syntax branch January 23, 2019 20:15
@bflad bflad modified the milestones: v2.0.0, v2.1.0, v2.2.0 Feb 24, 2019
@bflad bflad modified the milestones: v2.2.0, 0.12-support Mar 14, 2019
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/iot Issues and PRs that pertain to the iot service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants