Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/aws_sqs_queue: Timeout with incompatible arguments #41590

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Feb 27, 2025

Description

SQS has an unusual behavior where certain misconfigurations cause it to hang indefinitely rather than return an error. Specifically, creating or updating an aws_sqs_queue results in a timeout while waiting error if:

  • kms_data_key_reuse_period_seconds is set to a non-default value,
  • sqs_managed_sse_enabled is false (explicitly or by default), and
  • kms_master_key_id is not set.

While resourceQueueCustomizeDiff already handles kms_data_key_reuse_period_seconds in some cases, we don't modify configurations to prevent this hanging behavior. Instead of enforcing a change, this PR updates the documentation to make users aware of the issue. We could also connect kms_data_key_reuse_period_seconds, sqs_managed_sse_enabled, and kms_master_key_id to provide invalid configuration errors.

Relations

Relates #41234

References

Output from Acceptance Testing

N/A

@YakDriver YakDriver requested a review from a team as a code owner February 27, 2025 18:37
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/sqs Issues and PRs that pertain to the sqs service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Feb 27, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jar-b jar-b merged commit cc46d89 into main Feb 27, 2025
41 checks passed
@jar-b jar-b deleted the d-add-sqs-queue-note branch February 27, 2025 20:46
@github-actions github-actions bot added this to the v5.89.0 milestone Feb 27, 2025
Copy link

This functionality has been released in v5.89.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/sqs Issues and PRs that pertain to the sqs service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants