Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Remove AWS SDK for Go v1 support from internal/generate/tags #39913

Merged
merged 24 commits into from
Oct 28, 2024
Merged

Tech debt: Remove AWS SDK for Go v1 support from internal/generate/tags #39913

merged 24 commits into from
Oct 28, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Oct 28, 2024 •
edited
Loading

Description

Removes AWS SDK for Go v1 from the internal/generate/tags generator.

Relations

Relates #39280.
Relates #39840.
Relates #32976.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSecretsManagerSecretsDataSource_' PKG=secretsmanager
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/secretsmanager/... -v -count 1 -parallel 20  -run=TestAccSecretsManagerSecretsDataSource_ -timeout 360m
2024/10/28 16:43:52 Initializing Terraform AWS Provider...
=== RUN   TestAccSecretsManagerSecretsDataSource_filter
=== PAUSE TestAccSecretsManagerSecretsDataSource_filter
=== CONT  TestAccSecretsManagerSecretsDataSource_filter
--- PASS: TestAccSecretsManagerSecretsDataSource_filter (47.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager	52.683s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/lambda Issues and PRs that pertain to the lambda service. service/iam Issues and PRs that pertain to the iam service. service/s3 Issues and PRs that pertain to the s3 service. service/guardduty Issues and PRs that pertain to the guardduty service. service/apigateway Issues and PRs that pertain to the apigateway service. service/codebuild Issues and PRs that pertain to the codebuild service. service/sqs Issues and PRs that pertain to the sqs service. service/glacier Issues and PRs that pertain to the glacier service. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. service/medialive Issues and PRs that pertain to the medialive service. service/opsworks Issues and PRs that pertain to the opsworks service. service/codecommit Issues and PRs that pertain to the codecommit service. service/mq Issues and PRs that pertain to the mq service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/appsync Issues and PRs that pertain to the appsync service. labels Oct 28, 2024
@github-actions github-actions bot added service/internetmonitor Issues and PRs that pertain to the internetmonitor service. service/lexv2models Issues and PRs that pertain to the lexv2models service. service/m2 Issues and PRs that pertain to the m2 service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/datazone Issues and PRs that pertain to the datazone service. service/route53profiles Issues and PRs that pertain to the route53profiles service. service/timestreaminfluxdb Issues and PRs that pertain to the timestreaminfluxdb service. service/networkmonitor Issues and PRs that pertain to the networkmonitor service. labels Oct 28, 2024
@ewbankkit ewbankkit marked this pull request as ready for review October 28, 2024 16:22
@ewbankkit ewbankkit requested a review from a team as a code owner October 28, 2024 16:22
jar-b
jar-b approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Nice!

@ewbankkit
internal/generate/tags: 'ListTagsInIDNeedValueSlice' -> bool.
e26094e
@ewbankkit
internal/generate/tags: 'TagInIDNeedValueSlice' -> bool.
b208997
@ewbankkit
Add 'names.ToSnakeCase'.
edcc22c
@ewbankkit
internal/generate/tags: 'UntagInNeedTagKeyType' -> bool.
154239a
@ewbankkit
'internal/generate/namevaluesfilters/v2' -> 'internal/generate/nameva…
39ba4e9 
…luesfilters'.
@ewbankkit
Some 'internal/namevaluesfilters/v2' -> 'internal/namevaluesfilters'.
d1d4437
@ewbankkit
Complete 'internal/namevaluesfilters/v2' -> 'internal/namevaluesfilte…
6239e17 
…rs'.
@ewbankkit
'internal/namevaluesfilters/v2' -> 'internal/namevaluesfilters' - ima…
819b226 
…gebuilder.
@ewbankkit
'internal/namevaluesfilters/v2' -> 'internal/namevaluesfilters' - lic…
1303152 
…ensemanager.
@ewbankkit
'internal/namevaluesfilters/v2' -> 'internal/namevaluesfilters' - rds.
6464a6d
@ewbankkit
'internal/namevaluesfilters/v2' -> 'internal/namevaluesfilters' - rou…
9605ee2 
…te53resolver.
@ewbankkit
'internal/namevaluesfilters/v2' -> 'internal/namevaluesfilters' - sec…
cdba5de 
…retsmanager.
@ewbankkit ewbankkit merged commit 571e4d8 into main Oct 28, 2024
40 checks passed
@ewbankkit ewbankkit deleted the td-generators-remove-aws-sdk-go-supported branch October 28, 2024 21:01
@github-actions github-actions bot added this to the v5.74.0 milestone Oct 28, 2024
@ewbankkit ewbankkit mentioned this pull request Oct 29, 2024
Merged
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/amp Issues and PRs that pertain to the amp service. service/amplify Issues and PRs that pertain to the amplify service. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. service/appconfig Issues and PRs that pertain to the appconfig service. service/appflow Issues and PRs that pertain to the appflow service. service/appintegrations Issues and PRs that pertain to the appintegrations service. service/appstream Issues and PRs that pertain to the appstream service. service/appsync Issues and PRs that pertain to the appsync service. service/auditmanager Issues and PRs that pertain to the auditmanager service. service/backup Issues and PRs that pertain to the backup service. service/batch Issues and PRs that pertain to the batch service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codecommit Issues and PRs that pertain to the codecommit service. service/codeguruprofiler Issues and PRs that pertain to the codeguruprofiler service. service/codegurureviewer Issues and PRs that pertain to the codegurureviewer service. service/codestarnotifications Issues and PRs that pertain to the codestarnotifications service. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/connect Issues and PRs that pertain to the connect service. service/controltower Issues and PRs that pertain to the controltower service. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. service/databrew Issues and PRs that pertain to the databrew service. service/dataexchange Issues and PRs that pertain to the dataexchange service. service/datazone Issues and PRs that pertain to the datazone service. service/detective Issues and PRs that pertain to the detective service. service/dlm Issues and PRs that pertain to the dlm service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/drs Issues and PRs that pertain to the drs service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/eks Issues and PRs that pertain to the eks service. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. service/emrserverless Issues and PRs that pertain to the emrserverless service. service/evidently Issues and PRs that pertain to the evidently service. service/finspace Issues and PRs that pertain to the finspace service. service/fis Issues and PRs that pertain to the fis service. service/glacier Issues and PRs that pertain to the glacier service. service/glue Issues and PRs that pertain to the glue service. service/grafana Issues and PRs that pertain to the grafana service. service/greengrass Issues and PRs that pertain to the greengrass service. service/guardduty Issues and PRs that pertain to the guardduty service. service/healthlake Issues and PRs that pertain to the healthlake service. service/iam Issues and PRs that pertain to the iam service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/internetmonitor Issues and PRs that pertain to the internetmonitor service. service/ivs Issues and PRs that pertain to the ivs service. service/ivschat Issues and PRs that pertain to the ivschat service. service/kafka Issues and PRs that pertain to the kafka service. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. service/kinesisvideo Issues and PRs that pertain to the kinesisvideo service. service/lambda Issues and PRs that pertain to the lambda service. service/lexv2models Issues and PRs that pertain to the lexv2models service. service/location Issues and PRs that pertain to the location service. service/logs Issues and PRs that pertain to the logs service. service/lookoutmetrics Issues and PRs that pertain to the lookoutmetrics service. service/m2 Issues and PRs that pertain to the m2 service. service/macie2 Issues and PRs that pertain to the macie2 service. service/mediaconnect Issues and PRs that pertain to the mediaconnect service. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. service/medialive Issues and PRs that pertain to the medialive service. service/mediapackage Issues and PRs that pertain to the mediapackage service. service/mq Issues and PRs that pertain to the mq service. service/mwaa Issues and PRs that pertain to the mwaa service. service/networkmonitor Issues and PRs that pertain to the networkmonitor service. service/oam Issues and PRs that pertain to the oam service. service/opsworks Issues and PRs that pertain to the opsworks service. service/outposts Issues and PRs that pertain to the outposts service. service/pipes Issues and PRs that pertain to the pipes service. service/qldb Issues and PRs that pertain to the qldb service. service/rekognition Issues and PRs that pertain to the rekognition service. service/resiliencehub Issues and PRs that pertain to the resiliencehub service. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. service/resourcegroups Issues and PRs that pertain to the resourcegroups service. service/resourcegroupstaggingapi Issues and PRs that pertain to the resourcegroupstaggingapi service. service/route53profiles Issues and PRs that pertain to the route53profiles service. service/route53recoveryreadiness Issues and PRs that pertain to the route53recoveryreadiness service. service/rum Issues and PRs that pertain to the rum service. service/s3control Issues and PRs that pertain to the s3control service. service/s3 Issues and PRs that pertain to the s3 service. service/schemas Issues and PRs that pertain to the schemas service. service/securityhub Issues and PRs that pertain to the securityhub service. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/servicecatalogappregistry Issues and PRs that pertain to the servicecatalogappregistry service. service/signer Issues and PRs that pertain to the signer service. service/sqs Issues and PRs that pertain to the sqs service. service/ssmincidents Issues and PRs that pertain to the ssmincidents service. service/synthetics Issues and PRs that pertain to the synthetics service. service/timestreaminfluxdb Issues and PRs that pertain to the timestreaminfluxdb service. service/transfer Issues and PRs that pertain to the transfer service. service/vpclattice Issues and PRs that pertain to the vpclattice service. service/wellarchitected Issues and PRs that pertain to the wellarchitected service. service/worklink Issues and PRs that pertain to the worklink service.
Projects
None yet
Milestone
v5.74.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @jar-b