Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_cloudfront_distribution: Validate origin domain_name and origin_id at plan time #3767

Merged

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 13, 2018

Possibly related: #3766

Previously:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudFrontDistribution_emptyDomainName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCloudFrontDistribution_emptyDomainName -timeout 120m
=== RUN   TestAccAWSCloudFrontDistribution_emptyDomainName
--- FAIL: TestAccAWSCloudFrontDistribution_emptyDomainName (3.33s)
	testing.go:506: Step 0, expected error:

		Error applying: 1 error(s) occurred:

		* aws_cloudfront_distribution.emptyDomainName: 1 error(s) occurred:

		* aws_cloudfront_distribution.emptyDomainName: InvalidArgument: The parameter origin name cannot be null or empty.
			status code: 400, request id: e9192d20-26fe-11e8-9203-d143c667b144

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID -timeout 120m
=== RUN   TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID
--- FAIL: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (3.46s)
	testing.go:506: Step 0, expected error:

		Error applying: 1 error(s) occurred:

		* aws_cloudfront_distribution.Origin_EmptyOriginID: 1 error(s) occurred:

		* aws_cloudfront_distribution.Origin_EmptyOriginID: NoSuchOrigin: One or more of your origins do not exist.
			status code: 404, request id: 485540a6-2700-11e8-94ed-dda08547c7d9

Now:

 make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudFrontDistribution_Origin_Empty'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCloudFrontDistribution_Origin_Empty -timeout 120m
=== RUN   TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (1.63s)
=== RUN   TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (0.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.511s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service. labels Mar 13, 2018
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Mar 13, 2018
@bflad bflad added this to the v1.12.0 milestone Mar 14, 2018
@bflad bflad merged commit 86ba1fc into master Mar 20, 2018
@bflad bflad deleted the b-aws_cloudfront_distribution-domain_name-validatefunc branch March 20, 2018 12:33
bflad added a commit that referenced this pull request Mar 20, 2018
@bflad
Copy link
Contributor Author

bflad commented Mar 23, 2018

This has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants