Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/aws_dynamodb_global_table: Use single region for basic and import testing #3150

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 26, 2018

Due to limitations with the import process, this fails in acceptance testing when there are multiple regions involved:

=== RUN   TestAccAwsDynamoDbGlobalTable_import
--- FAIL: TestAccAwsDynamoDbGlobalTable_import (34.04s)
    testing.go:573: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: config is invalid: aws_dynamodb_global_table.test: configuration for provider.aws.us-east-1 is not present; a provider configuration block is required for all operations

Basic/import testing should have been one region anyways. My bad. 🤕

Passing for me locally and I'll run it in TeamCity.

make testacc TEST=./aws TESTARGS='-run=TestAccAwsDynamoDbGlobalTable'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAwsDynamoDbGlobalTable -timeout 120m
=== RUN   TestAccAwsDynamoDbGlobalTable_basic
--- PASS: TestAccAwsDynamoDbGlobalTable_basic (87.11s)
=== RUN   TestAccAwsDynamoDbGlobalTable_multipleRegions
--- PASS: TestAccAwsDynamoDbGlobalTable_multipleRegions (104.13s)
=== RUN   TestAccAwsDynamoDbGlobalTable_import
--- PASS: TestAccAwsDynamoDbGlobalTable_import (85.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	277.125s

@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dynamodb Issues and PRs that pertain to the dynamodb service. labels Jan 26, 2018
@bflad bflad merged commit 1507f6c into master Jan 26, 2018
@bflad bflad deleted the t-aws_dynamodb_global_table-import branch January 26, 2018 17:05
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/dynamodb Issues and PRs that pertain to the dynamodb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants