Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new service aws_vpclattice_service_network_vpc_association #30544

Conversation

meetreks
Copy link
Contributor

@meetreks meetreks commented Apr 8, 2023

Description

This pull request will cater for a new resource in the VPC Lattice family - ServiceNetwork - VPC Association. For more information kindly refer to this page for details - https://docs.aws.amazon.com/vpc-lattice/latest/ug/service-network-associations.html

Relations

Closes #30411.
Relates #30380.

References

The API Reference can be found here - https://docs.aws.amazon.com/vpc-lattice/latest/APIReference/API_CreateServiceNetworkVpcAssociation.html

Output from Acceptance Testing

:~/terraform-provider-aws (f-aws_vpclattice_service_network_vpc_association) $ make testacc PKG=vpclattice TESTS=TestAccVPCLatticeServiceNetworkVPCAssociation_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 20 -run='TestAccVPCLatticeServiceNetworkVPCAssociation_'  -timeout 180m
=== RUN   TestAccVPCLatticeServiceNetworkVPCAssociation_basic
=== PAUSE TestAccVPCLatticeServiceNetworkVPCAssociation_basic
=== RUN   TestAccVPCLatticeServiceNetworkVPCAssociation_disappears
=== PAUSE TestAccVPCLatticeServiceNetworkVPCAssociation_disappears
=== RUN   TestAccVPCLatticeServiceNetworkVPCAssociation_full
=== PAUSE TestAccVPCLatticeServiceNetworkVPCAssociation_full
=== RUN   TestAccVPCLatticeServiceNetworkVPCAssociation_tags
=== PAUSE TestAccVPCLatticeServiceNetworkVPCAssociation_tags
=== CONT  TestAccVPCLatticeServiceNetworkVPCAssociation_basic
=== CONT  TestAccVPCLatticeServiceNetworkVPCAssociation_full
=== CONT  TestAccVPCLatticeServiceNetworkVPCAssociation_tags
=== CONT  TestAccVPCLatticeServiceNetworkVPCAssociation_disappears
--- PASS: TestAccVPCLatticeServiceNetworkVPCAssociation_tags (107.69s)
--- PASS: TestAccVPCLatticeServiceNetworkVPCAssociation_full (124.28s)
--- PASS: TestAccVPCLatticeServiceNetworkVPCAssociation_basic (136.76s)
--- PASS: TestAccVPCLatticeServiceNetworkVPCAssociation_disappears (184.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice 184.237s

...

@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/vpclattice Issues and PRs that pertain to the vpclattice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Apr 8, 2023
@ewbankkit ewbankkit added new-resource Introduces a new resource. partner Contribution from a partner. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 10, 2023
@ewbankkit ewbankkit self-assigned this Apr 10, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCLatticeServiceNetworkVPCAssociation_' PKG=vpclattice ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 2  -run=TestAccVPCLatticeServiceNetworkVPCAssociation_ -timeout 180m
=== RUN   TestAccVPCLatticeServiceNetworkVPCAssociation_basic
=== PAUSE TestAccVPCLatticeServiceNetworkVPCAssociation_basic
=== RUN   TestAccVPCLatticeServiceNetworkVPCAssociation_disappears
=== PAUSE TestAccVPCLatticeServiceNetworkVPCAssociation_disappears
=== RUN   TestAccVPCLatticeServiceNetworkVPCAssociation_full
=== PAUSE TestAccVPCLatticeServiceNetworkVPCAssociation_full
=== RUN   TestAccVPCLatticeServiceNetworkVPCAssociation_tags
=== PAUSE TestAccVPCLatticeServiceNetworkVPCAssociation_tags
=== CONT  TestAccVPCLatticeServiceNetworkVPCAssociation_basic
=== CONT  TestAccVPCLatticeServiceNetworkVPCAssociation_full
--- PASS: TestAccVPCLatticeServiceNetworkVPCAssociation_full (85.54s)
=== CONT  TestAccVPCLatticeServiceNetworkVPCAssociation_disappears
--- PASS: TestAccVPCLatticeServiceNetworkVPCAssociation_disappears (50.84s)
=== CONT  TestAccVPCLatticeServiceNetworkVPCAssociation_tags
--- PASS: TestAccVPCLatticeServiceNetworkVPCAssociation_basic (182.14s)
--- PASS: TestAccVPCLatticeServiceNetworkVPCAssociation_tags (81.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	223.504s

@ewbankkit
Copy link
Contributor

@meetreks Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 9031093 into hashicorp:main Apr 10, 2023
@github-actions github-actions bot added this to the v4.63.0 milestone Apr 10, 2023
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/vpclattice Issues and PRs that pertain to the vpclattice service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_vpclattice_service_network_vpc_association
2 participants