-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_lambda_functions: new data resource #28254
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @phzietsman 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
…h a single newline character'.
…proper order: ["Std" "Third party" "Third party"]'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccLambdaFunctionsDataSource_' PKG=lambda ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 3 -run=TestAccLambdaFunctionsDataSource_ -timeout 180m
=== RUN TestAccLambdaFunctionsDataSource_basic
=== PAUSE TestAccLambdaFunctionsDataSource_basic
=== CONT TestAccLambdaFunctionsDataSource_basic
--- PASS: TestAccLambdaFunctionsDataSource_basic (41.36s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lambda 46.559s
@phzietsman Thanks for the contribution 🎉 👏. |
@ewbankkit thanks for the fixes! |
This functionality has been released in v4.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR introduces the
aws_lambda_functions
plural data source.Relations
Closes #24522
Closes #17701
References
The Go AWS SDK does not support filters, for maintainability custom filters were not implemented in the provider.
https://docs.aws.amazon.com/sdk-for-go/api/service/lambda/#ListFunctionsInput
Output from Acceptance Testing