Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: aws_lightsail_domain_entry id field update separator to , to support _ in txt records #27791

Conversation

brittandeyoung
Copy link
Collaborator

@brittandeyoung brittandeyoung commented Nov 14, 2022

Description

The current separator used for the custom id field uses _ as a separator. This causes issues when creating txt records which commonly have _ inside the record. This also updates the separator to be the same as the rest of the lightsail resources.

Relations

Relates #27843
Closes: #27927

References

Output from Acceptance Testing

$  make testacc TESTARGS='-run=TestAccLightsailDomainEntry' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailDomainEntry -timeout 180m
=== RUN   TestAccLightsailDomainEntry_basic
=== PAUSE TestAccLightsailDomainEntry_basic
=== RUN   TestAccLightsailDomainEntry_disappears
=== PAUSE TestAccLightsailDomainEntry_disappears
=== CONT  TestAccLightsailDomainEntry_basic
=== CONT  TestAccLightsailDomainEntry_disappears
--- PASS: TestAccLightsailDomainEntry_disappears (50.59s)
--- PASS: TestAccLightsailDomainEntry_basic (53.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  55.779s

...

* Change id field to use "," seperator as "_" is used in txt records and causes an issue when creating these records.
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/lightsail Issues and PRs that pertain to the lightsail service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed service/lightsail Issues and PRs that pertain to the lightsail service. labels Nov 14, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/lightsail Issues and PRs that pertain to the lightsail service. labels Nov 14, 2022
@brittandeyoung brittandeyoung added bug Addresses a defect in current functionality. breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. labels Nov 15, 2022
@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Nov 16, 2022
@YakDriver YakDriver self-assigned this Feb 10, 2023
@YakDriver YakDriver added this to the v5.0.0 milestone Feb 10, 2023
@YakDriver YakDriver removed their assignment Feb 10, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
@jar-b jar-b removed this from the v5.0.0 milestone May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/lightsail Issues and PRs that pertain to the lightsail service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_lightsail_domain_entry fails to read when record contains _
3 participants