Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/support new datalake settings arguments #27042

Conversation

simonvdk
Copy link

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Description

API now accepts more arguments for datalake settings (namely AllowExternalDataFiltering, ExternalDataFilteringAllowList and AuthorizedSessionTagValueList).

This PR aims to add the related arguments to the aws_lakeformation_data_lake_settings resource, and the corresponding attributes to the data source.

Relations

Closes #26932

References

API doc

Output from Acceptance Testing

$ make testacc TESTS=TestAccLakeFormation_serial/DataLakeSettings PKG=lakeformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run='TestAccLakeFormation_serial/DataLakeSettings'  -timeout 180m
=== RUN   TestAccLakeFormation_serial
=== RUN   TestAccLakeFormation_serial/DataLakeSettings
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/disappears
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/withoutCatalogId
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/basic
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/dataSource
--- PASS: TestAccLakeFormation_serial (134.96s)
    --- PASS: TestAccLakeFormation_serial/DataLakeSettings (134.96s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/disappears (34.79s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/withoutCatalogId (31.63s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/basic (31.95s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/dataSource (36.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	135.044s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/lakeformation Issues and PRs that pertain to the lakeformation service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Sep 30, 2022
@simonvdk simonvdk force-pushed the feat/support_new_datalake_settings_arguments branch from 11ac43f to d2b93e7 Compare September 30, 2022 15:37
@simonvdk simonvdk marked this pull request as draft September 30, 2022 15:44
@simonvdk simonvdk force-pushed the feat/support_new_datalake_settings_arguments branch from d2b93e7 to dfda2ba Compare September 30, 2022 16:16
@simonvdk simonvdk marked this pull request as ready for review October 5, 2022 08:05
@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 11, 2022
Copy link

github-actions bot commented Oct 1, 2024

Marking this pull request as stale due to inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Oct 1, 2024
@github-actions github-actions bot closed this Nov 2, 2024
Copy link

github-actions bot commented Dec 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/M Managed by automation to categorize the size of a PR. stale Old or inactive issues managed by automation, if no further action taken these will get closed. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support new aws_lakeformation_data_lake_settings argument for credentials vending
2 participants