Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linting: Add yamllint #26149

Merged
merged 4 commits into from
Aug 5, 2022
Merged

linting: Add yamllint #26149

merged 4 commits into from
Aug 5, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Aug 5, 2022

Adds yamllint linting for all YAML files.

Uses the default ruleset with the following exceptions:

  • Requires only 1 space before comments (default is 2)
  • Does not require the document start marker (---)
  • Does not limit line length
  • Does not check for truthy values in keys. Otherwise this would flag the on key in GitHub workflows

Adds GitHub workflow and makefile rule

@github-actions github-actions bot added examples Introduces or discusses updates to examples. generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/cloudformation Issues and PRs that pertain to the cloudformation service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Aug 5, 2022
ewbankkit
ewbankkit approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit f12c95e into main Aug 5, 2022
@gdavison gdavison deleted the td-yamllint branch August 5, 2022 20:52
@github-actions github-actions bot added this to the v4.26.0 milestone Aug 5, 2022
@github-actions
Copy link

This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
examples Introduces or discusses updates to examples. generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/cloudformation Issues and PRs that pertain to the cloudformation service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit