Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_route53_cidr_collection + support IP based routing #25797

Conversation

bschaatsbergen
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25321

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=route53

...

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/route53 Issues and PRs that pertain to the route53 service. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. labels Jul 12, 2022
@bschaatsbergen
Copy link
Member Author

Still quite some work to be done here, putting the draft out already.

@bschaatsbergen
Copy link
Member Author

On hold for a moment; checking together with @ewbankkit on how to nicely integrate this with the existing Route53 CidrCollection API.

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 23, 2022
@JoeAshworth
Copy link

Hey, how is progress going with this?

@bschaatsbergen
Copy link
Member Author

Closing this PR, we can reopen it later..

@JoeAshworth
Copy link

So this is just being given up on?

@bschaatsbergen
Copy link
Member Author

It's definitely not @JoeAshworth, we aim to pick this up whenever it lands on the roadmap. Feel free to take a stab at it if you like, I'm happy to help. The reason I didn't invest more time into the PR is because the API spec at the time was very poor, I haven't had time to revisit it yet.

@bschaatsbergen
Copy link
Member Author

I'll revisit the API spec somewhere next week and get back to you.

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
@bschaatsbergen bschaatsbergen deleted the r/#25321-add-ip-based-routing-support-to-route53 branch March 18, 2023 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Route 53 IP Based Routing Policy
3 participants