Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: github.com/hashicorp/terraform/[email protected] #2185

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

radeksimko
Copy link
Member

This is mainly to take advantage of hashicorp/terraform#16506 and fix a couple of our acceptance tests which are currently crashing.

@radeksimko radeksimko added the dependencies Used to indicate dependency changes. label Nov 6, 2017
@stack72
Copy link
Contributor

stack72 commented Nov 6, 2017

@radeksimko is taking a vendor on not a beta a risky idea? Do we know what the feedback is on the beta? Or is this low key?

@radeksimko
Copy link
Member Author

Firstly I think we'll find out soon from the acceptance tests and if not, I don't know how else.
Secondly there's a very low chance of breaking anything because providers generally only vendor hashicorp/terraform because of all the helper (schema etc.) packages, which should be compatible - if not, we'll see it soon in acceptance tests and we can fix it before cutting next provider release 😉

Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this and see if it fixes our tests! 😄

@radeksimko radeksimko merged commit 95f2651 into master Nov 7, 2017
@radeksimko radeksimko deleted the vendor-hc-tf branch November 7, 2017 09:58
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants