Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support timeouts block for resource aws_ec2_client_vpn_network_association #20689

Merged
merged 10 commits into from
Jan 31, 2022
Merged

support timeouts block for resource aws_ec2_client_vpn_network_association #20689

merged 10 commits into from
Jan 31, 2022

Conversation

joeperks
Copy link

@joeperks joeperks commented Aug 25, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #17800

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsEc2ClientVpnNetworkAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=testAccAwsEc2ClientVpnNetworkAssociation_ -timeout 180m
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       0.083s [no tests to run]
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. labels Aug 25, 2021
@joeperks joeperks force-pushed the f-resource_aws_ec2_client_vpn_network_association-add-timeouts-support branch from b4e63e9 to 3de43c6 Compare August 27, 2021 14:23
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Aug 27, 2021
@joeperks joeperks changed the title [WIP] adding support for timeouts block [WIP] support timeouts block for resource aws_ec2_client_vpn_network_association Aug 27, 2021
@joeperks joeperks marked this pull request as ready for review August 27, 2021 18:41
@joeperks joeperks changed the title [WIP] support timeouts block for resource aws_ec2_client_vpn_network_association support timeouts block for resource aws_ec2_client_vpn_network_association Aug 27, 2021
@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 27, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@ewbankkit
Revert "Client vpn endpoint not found implies authorization rule does…
6dd6e0f 
… not exists"

This reverts commit 4ffbdea.
@ewbankkit
Revert "docs and changelog"
0c45960 
This reverts commit 8876e88.
@ewbankkit
Revert "adding support for timeouts block"
474c03b 
This reverts commit 3de43c6.
@ewbankkit
Merge branch 'main' into HEAD
85e3664
@ewbankkit
Merge branch 'tmp-pr15699' into HEAD
f50eff3
@ewbankkit
r/aws_ec2_client_vpn_authorization_rule: Tidy up and check for `Inval…
b89cb8e 
…idClientVpnEndpointId.NotFound` in `FindClientVPNAuthorizationRules` (hashicorp#15699).

Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule -timeout 180m
=== RUN   TestAccEC2ClientVPNEndpoint_serial
=== PAUSE TestAccEC2ClientVPNEndpoint_serial
=== CONT  TestAccEC2ClientVPNEndpoint_serial
=== RUN   TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets
=== RUN   TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears
=== RUN   TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== RUN   TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic
=== RUN   TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups
=== CONT  TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets
=== CONT  TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic
=== CONT  TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== CONT  TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups
=== CONT  TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears
--- PASS: TestAccEC2ClientVPNEndpoint_serial (1.11s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint (57.33s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears (61.52s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic (68.40s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets (99.99s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups (125.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        130.096s
@ewbankkit
r/aws_ec2_client_vpn_authorization_rule: Add custom Create and Delete…
06f80c8 
… timeouts.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic -timeout 180m
=== RUN   TestAccEC2ClientVPNEndpoint_serial
=== PAUSE TestAccEC2ClientVPNEndpoint_serial
=== CONT  TestAccEC2ClientVPNEndpoint_serial
=== RUN   TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic
=== CONT  TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic
--- PASS: TestAccEC2ClientVPNEndpoint_serial (0.10s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic (61.90s)
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 31, 2022
@ewbankkit ewbankkit merged commit e4772dc into hashicorp:main Jan 31, 2022
@github-actions github-actions bot added this to the v4.0.0 milestone Jan 31, 2022
@ewbankkit
Copy link
Contributor

@joeperks Thanks for the contribution 🎉 👏.
The changes have been rolled into #14218.

@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@joeperks @zhelding @ewbankkit @breathingdust @wparad