Support AWS AppFlow: aws_appflow_connector_profile resource

[szemek]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16253

Description

Adds aws_appflow_connector_profile resource for #16253

Release note for CHANGELOG:

New Resource: aws_appflow_connector_profile

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAppFlowConnectorProfile_'

=== RUN   TestAccAWSAppFlowConnectorProfile_Amplitude
--- PASS: TestAccAWSAppFlowConnectorProfile_Amplitude (50.52s)
=== RUN   TestAccAWSAppFlowConnectorProfile_Datadog
--- PASS: TestAccAWSAppFlowConnectorProfile_Datadog (43.21s)
=== RUN   TestAccAWSAppFlowConnectorProfile_Dynatrace
--- PASS: TestAccAWSAppFlowConnectorProfile_Dynatrace (39.32s)
=== RUN   TestAccAWSAppFlowConnectorProfile_Slack
--- PASS: TestAccAWSAppFlowConnectorProfile_Slack (40.97s)
=== RUN   TestAccAWSAppFlowConnectorProfile_Snowflake
--- PASS: TestAccAWSAppFlowConnectorProfile_Snowflake (50.58s)
=== RUN   TestAccAWSAppFlowConnectorProfile_Trendmicro
--- PASS: TestAccAWSAppFlowConnectorProfile_Trendmicro (40.55s)
=== RUN   TestAccAWSAppFlowConnectorProfile_Zendesk
--- PASS: TestAccAWSAppFlowConnectorProfile_Zendesk (43.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	308.558s

⚠️ Tests require credentials for externals services. I passed them as environment variables. In case of missing environment variable the test is skipped.

$ make testacc TESTARGS='-run=TestAccAWSAppFlowConnectorProfile_'

=== RUN   TestAccAWSAppFlowConnectorProfile_Amplitude
    resource_aws_appflow_connector_profile_test.go:26: All environment variables: AMPLITUDE_API_KEY, AMPLITUDE_SECRET_KEY must be set.
--- SKIP: TestAccAWSAppFlowConnectorProfile_Amplitude (0.00s)
=== RUN   TestAccAWSAppFlowConnectorProfile_Datadog
    resource_aws_appflow_connector_profile_test.go:76: All environment variables: DATADOG_API_KEY, DATADOG_APPLICATION_KEY, DATADOG_INSTANCE_URL must be set.
--- SKIP: TestAccAWSAppFlowConnectorProfile_Datadog (0.00s)
=== RUN   TestAccAWSAppFlowConnectorProfile_Dynatrace
    resource_aws_appflow_connector_profile_test.go:126: All environment variables: DYNATRACE_API_TOKEN, DYNATRACE_INSTANCE_URL must be set.
--- SKIP: TestAccAWSAppFlowConnectorProfile_Dynatrace (0.00s)
=== RUN   TestAccAWSAppFlowConnectorProfile_Slack
    resource_aws_appflow_connector_profile_test.go:177: All environment variables: SLACK_CLIENT_ID, SLACK_CLIENT_SECRET, SLACK_ACCESS_TOKEN, SLACK_INSTANCE_URL must be set.
--- SKIP: TestAccAWSAppFlowConnectorProfile_Slack (0.00s)
=== RUN   TestAccAWSAppFlowConnectorProfile_Snowflake
    resource_aws_appflow_connector_profile_test.go:235: All environment variables: SNOWFLAKE_PASSWORD, SNOWFLAKE_USERNAME, SNOWFLAKE_ACCOUNT_NAME, SNOWFLAKE_REGION, SNOWFLAKE_STAGE, SNOWFLAKE_WAREHOUSE must be set.
--- SKIP: TestAccAWSAppFlowConnectorProfile_Snowflake (0.00s)
=== RUN   TestAccAWSAppFlowConnectorProfile_Trendmicro
    resource_aws_appflow_connector_profile_test.go:288: All environment variables: TRENDMICRO_API_SECRET_KEY must be set.
--- SKIP: TestAccAWSAppFlowConnectorProfile_Trendmicro (0.00s)
=== RUN   TestAccAWSAppFlowConnectorProfile_Zendesk
    resource_aws_appflow_connector_profile_test.go:337: All environment variables: ZENDESK_CLIENT_ID, ZENDESK_CLIENT_SECRET, ZENDESK_ACCESS_TOKEN, ZENDESK_INSTANCE_URL must be set.
--- SKIP: TestAccAWSAppFlowConnectorProfile_Zendesk (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.081s

[mitchellrj]

Since it's hard to create some connector profiles outside of the console (e.g. SalesForce), could this also include a data source for the connector profile?

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.