Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the force new on provisioning_artifact_parameters #19408

Closed
wants to merge 1 commit into from

Conversation

zopanix
Copy link
Contributor

@zopanix zopanix commented May 17, 2021

We should be able to edit this attribute to release new versions of the product and/or remove older versions

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Need help filling everything out

We should be able to edit this attribute to release new versions of the product and/or remove older versions
@zopanix zopanix requested a review from a team as a code owner May 17, 2021 18:05
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. labels May 17, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 17, 2021
@zopanix
Copy link
Contributor Author

zopanix commented May 21, 2021

This should not be necessary anymore thanks to several other merges

@zopanix zopanix closed this May 21, 2021
@zopanix zopanix reopened this May 21, 2021
@zopanix
Copy link
Contributor Author

zopanix commented May 21, 2021

Sorry, I tought this was resolved but it isn't

@ewbankkit
Copy link
Contributor

@zopanix Thanks for the contribution 👏.
Is #19506 the issue that you are seeing?

@ewbankkit ewbankkit added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels May 25, 2021
@zopanix
Copy link
Contributor Author

zopanix commented May 25, 2021

@ewbankkit : Sorry, no, in my case, it tries to recreate the resource. There might have been another PR merged in the meanwhile. I'll test it and check it later on today and post a comment

FYI: my initial use case was using an imported resource so issue might be different

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label May 25, 2021
@ewbankkit
Copy link
Contributor

@zopanix Could you add the output from terraform plan that shows the resource recreation? Thanks.

@bill-rich
Copy link
Contributor

Since its been a while since the last response, I'm going to close this. If its still a problem, please open a new PR along with the output from terraform plan that shows the recreation.

@bill-rich bill-rich closed this Jul 30, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants