Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_dax_cluster #1722

Closed
wants to merge 3 commits into from
Closed

New Resource: aws_dax_cluster #1722

wants to merge 3 commits into from

Conversation

gazoakley
Copy link
Contributor

This adds support for managing AWS DynamoDB Accelerator (DAX). It adds a new aws_dax_cluster resource. There is code ready for a aws_dax_subnet_group but it is not present in this PR to simplify review.

@gazoakley gazoakley mentioned this pull request Sep 21, 2017
Closed
@radeksimko radeksimko added new-resource Introduces a new resource. enhancement Requests to existing resources that expand the functionality or scope. labels Sep 27, 2017
@gazoakley
Copy link
Contributor Author

@radeksimko Any chance of a review? This was previously opened as #1515 but split out to only have 1 resource for the first review

complexsplit
complexsplit reviewed Oct 9, 2017
View reviewed changes
website/docs/r/dax_cluster.html.markdown
```hcl
resource "aws_dax_cluster" "bar" {
cluster_id = "cluster-example"
iam_role_arn = "arn:aws:iams:us-east-1:012345678999"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an IAM role ARN looks like arn:aws:iam:us-east-1:123456789012:role/foo.

@radeksimko radeksimko added the size/XXL Managed by automation to categorize the size of a PR. label Nov 15, 2017
@Ninir
Copy link
Contributor

Ninir commented Nov 16, 2017

Hi @gazoakley

Do you think you could move the vendoring part into its own PR, so that it's easier to review this work? :)
Please note that we need to lock the service version so that we always match it exactly, and keep it in-sync with other AWS service versions.

Thanks!

@Ninir Ninir added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 16, 2017
@radeksimko radeksimko changed the title AWS DynamoDB Accelerator Support New Resource: aws_dax_cluster Nov 17, 2017
@gazoakley gazoakley closed this Jan 6, 2018
bflad added a commit that referenced this pull request Nov 4, 2019
@bflad
Update CHANGELOG for #1722
6287b73
@gazoakley gazoakley deleted the f-aws-dax-cluster-resource branch April 7, 2020 16:11
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@complexsplit complexsplit complexsplit left review comments

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gazoakley @Ninir @complexsplit @breathingdust @radeksimko