Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Migrate remaining PreConfig disappears testing to testAccCheckResourceDisappears #16305

Merged
merged 2 commits into from
Dec 3, 2020
Merged

tests/provider: Migrate remaining PreConfig disappears testing to testAccCheckResourceDisappears #16305

merged 2 commits into from
Dec 3, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 19, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13820

Release note for CHANGELOG:

NONE

Output from acceptance testing:

--- PASS: TestAccAWSAppCookieStickinessPolicy_disappears_ELB (16.05s)
--- PASS: TestAccAWSAppCookieStickinessPolicy_disappears (18.31s)

--- PASS: TestAccAWSEcsTaskDefinition_disappears (15.18s)

--- PASS: TestAccAWSGlueCatalogTable_disappears (10.65s)

--- PASS: TestAccAWSLBCookieStickinessPolicy_disappears_ELB (18.22s)
--- PASS: TestAccAWSLBCookieStickinessPolicy_disappears (21.69s)

--- PASS: TestAccAWSSSMAssociation_disappears (85.35s)

@bflad
tests/provider: Migrate remaining PreConfig disappears testing to tes…
668a75f 
…tAccCheckResourceDisappears

Reference: #13820

Output from acceptance testing:

```
--- PASS: TestAccAWSAppCookieStickinessPolicy_disappears_ELB (16.05s)
--- PASS: TestAccAWSAppCookieStickinessPolicy_disappears (18.31s)

--- PASS: TestAccAWSEcsTaskDefinition_disappears (15.18s)

--- PASS: TestAccAWSGlueCatalogTable_disappears (10.65s)

--- PASS: TestAccAWSLBCookieStickinessPolicy_disappears_ELB (18.22s)
--- PASS: TestAccAWSLBCookieStickinessPolicy_disappears (21.69s)

--- PASS: TestAccAWSSSMAssociation_disappears (85.35s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 19, 2020
@bflad bflad requested a review from a team as a code owner November 19, 2020 04:59
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/ecs Issues and PRs that pertain to the ecs service. service/elb Issues and PRs that pertain to the elb service. service/glue Issues and PRs that pertain to the glue service. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 19, 2020
bflad
bflad commented Nov 19, 2020
View reviewed changes
aws/resource_aws_glue_catalog_table_test.go
@@ -11,41 +11,6 @@ import (
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
)

func TestAccAWSGlueCatalogTable_recreates(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already handled by existing _disappears test:

--- PASS: TestAccAWSGlueCatalogTable_disappears (10.65s)

aws/resource_aws_ssm_association_test.go
@@ -532,7 +516,7 @@ func testAccCheckAWSSSMAssociationDestroy(s *terraform.State) error {
}
}

return fmt.Errorf("Default error in SSM Association Test")
return nil
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standardizing with all other resource CheckDestroy functions, otherwise returns error with _disappears testing since there are no resource states post-apply in that scenario. See also #15847

@bflad
tests/resource/aws_lb_cookie_stickiness_policy: Remove now unused con…
e31d389 
…figuration

Previously:

```
aws/resource_aws_lb_cookie_stickiness_policy_test.go:191:6: `testAccLBCookieStickinessPolicyConfigDestroy` is unused (deadcode)
func testAccLBCookieStickinessPolicyConfigDestroy(rName string) string {
     ^
```
@DrFaust92 DrFaust92 removed the service/glue Issues and PRs that pertain to the glue service. label Nov 24, 2020
anGie44
anGie44 approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯 💯

@bflad bflad added this to the v3.20.0 milestone Dec 3, 2020
@bflad bflad merged commit 89a8930 into master Dec 3, 2020
@bflad bflad deleted the td-migrate-PreConfig-disappears branch December 3, 2020 14:57
@ghost
Copy link

ghost commented Dec 3, 2020

This has been released in version 3.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
service/ecs Issues and PRs that pertain to the ecs service. service/elb Issues and PRs that pertain to the elb service. service/ssm Issues and PRs that pertain to the ssm service. size/L Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.20.0
Development

Successfully merging this pull request may close these issues.

Replace PreConfig Disappears Testing
3 participants
@bflad @anGie44 @DrFaust92