Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/ec2: Refactor aws_vpn_gateway data source and resource to use keyvaluetags package #11909

Merged
merged 1 commit into from
Feb 6, 2020
Merged

service/ec2: Refactor aws_vpn_gateway data source and resource to use keyvaluetags package #11909

merged 1 commit into from
Feb 6, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing:

--- PASS: TestAccAWSVpnGateway_disappears (43.96s)
--- PASS: TestAccAWSVpnGateway_withAvailabilityZoneSetToState (45.27s)
--- PASS: TestAccAWSVpnGateway_withAmazonSideAsnSetToState (57.28s)
--- PASS: TestAccAWSVpnGateway_tags (66.12s)
--- PASS: TestAccAWSVpnGateway_delete (67.27s)
--- PASS: TestAccAWSVpnGateway_basic (74.69s)
--- PASS: TestAccAWSVpnGateway_reattach (114.06s)

--- PASS: TestAccDataSourceAwsVpnGateway_unattached (18.47s)
--- PASS: TestAccDataSourceAwsVpnGateway_attached (54.18s)

@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Feb 5, 2020
@bflad bflad requested a review from a team February 5, 2020 17:56
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 5, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Feb 5, 2020
@bflad
service/ec2: Refactor aws_vpn_gateway data source and resource to use…
82c4ad2 
… keyvaluetags package

Reference: #10688

Output from acceptance testing:

```
--- PASS: TestAccAWSVpnGateway_disappears (43.96s)
--- PASS: TestAccAWSVpnGateway_withAvailabilityZoneSetToState (45.27s)
--- PASS: TestAccAWSVpnGateway_withAmazonSideAsnSetToState (57.28s)
--- PASS: TestAccAWSVpnGateway_tags (66.12s)
--- PASS: TestAccAWSVpnGateway_delete (67.27s)
--- PASS: TestAccAWSVpnGateway_basic (74.69s)
--- PASS: TestAccAWSVpnGateway_reattach (114.06s)

--- PASS: TestAccDataSourceAwsVpnGateway_unattached (18.47s)
--- PASS: TestAccDataSourceAwsVpnGateway_attached (54.18s)
```
@bflad bflad force-pushed the td-aws_vpn_gateway-keyvaluetags branch from d730bb9 to 82c4ad2 Compare February 5, 2020 19:40
gdavison
gdavison approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccDataSourceAwsVpnGateway_unattached (11.04s)
--- PASS: TestAccAWSVpnGatewayAttachment_basic (38.14s)
--- PASS: TestAccDataSourceAwsVpnGateway_attached (38.27s)
--- PASS: TestAccAWSVpnGatewayAttachment_deleted (42.03s)
--- PASS: TestAccAWSVpnGateway_basic (45.62s)
--- PASS: TestAccAWSVpnGateway_tags (47.65s)
--- PASS: TestAccAWSVpnGateway_withAmazonSideAsnSetToState (43.79s)
--- PASS: TestAccAWSVpnGateway_delete (57.56s)
--- PASS: TestAccAWSVpnGateway_withAvailabilityZoneSetToState (44.73s)
--- PASS: TestAccAWSVpnGateway_disappears (39.47s)
--- PASS: TestAccAWSVpnGateway_reattach (100.89s)

@bflad bflad added this to the v2.48.0 milestone Feb 6, 2020
@bflad bflad merged commit 9dbfedf into master Feb 6, 2020
@bflad bflad deleted the td-aws_vpn_gateway-keyvaluetags branch February 6, 2020 00:41
@ghost
Copy link

ghost commented Feb 7, 2020

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v2.48.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @gdavison