Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/provider: Fix markdownlint MD032 failures and enable rule #11875

Merged
merged 1 commit into from
Feb 5, 2020
Merged

docs/provider: Fix markdownlint MD032 failures and enable rule #11875

merged 1 commit into from
Feb 5, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 4, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #11838

Release note for CHANGELOG:

NONE

Previously:

website/docs/d/ebs_default_kms_key.html.markdown:28 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `key_arn` - Amazon Resource ..."]
website/docs/d/organizations_organizational_units.html.markdown:23 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `parent_id` - (Required) The..."]
website/docs/d/organizations_organizational_units.html.markdown:26 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `children` - List of child o..."]
website/docs/d/route53_zone.html.markdown:47 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "a pair on the desired Hosted Z..."]
website/docs/r/autoscaling_schedule.html.markdown:58 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `arn` - The ARN assigned by ..."]
website/docs/r/db_option_group.html.markdown:12 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* [MariaDB Options](https://do..."]
website/docs/r/db_parameter_group.html.markdown:12 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* [Aurora MySQL Parameters](ht..."]
website/docs/r/pinpoint_apns_channel.markdown:44 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `certificate` - (Required) T..."]
website/docs/r/pinpoint_apns_channel.markdown:48 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `bundle_id` - (Required) The..."]
website/docs/r/pinpoint_apns_sandbox_channel.markdown:44 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `certificate` - (Required) T..."]
website/docs/r/pinpoint_apns_sandbox_channel.markdown:48 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `bundle_id` - (Required) The..."]
website/docs/r/pinpoint_apns_voip_channel.markdown:44 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `certificate` - (Required) T..."]
website/docs/r/pinpoint_apns_voip_channel.markdown:48 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `bundle_id` - (Required) The..."]
website/docs/r/pinpoint_apns_voip_sandbox_channel.markdown:44 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `certificate` - (Required) T..."]
website/docs/r/pinpoint_apns_voip_sandbox_channel.markdown:48 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `bundle_id` - (Required) The..."]
website/docs/r/s3_bucket.html.markdown:419 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* For a specific rule, `prefix..."]
website/docs/r/sagemaker_endpoint_configuration.html.markdown:51 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `variant_name` - (Optional) ..."]
website/docs/r/spot_datafeed_subscription.html.markdown:30 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `bucket` - (Required) The Am..."]
website/docs/r/vpc_dhcp_options_association.html.markdown:30 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* You can only associate one D..."]
website/docs/r/vpc_dhcp_options.html.markdown:51 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* Notice that all arguments ar..."]

@bflad
docs/provider: Fix markdownlint MD032 failures and enable rule
56aa292 
Reference: #11838

Previously:

```
website/docs/d/ebs_default_kms_key.html.markdown:28 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `key_arn` - Amazon Resource ..."]
website/docs/d/organizations_organizational_units.html.markdown:23 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `parent_id` - (Required) The..."]
website/docs/d/organizations_organizational_units.html.markdown:26 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `children` - List of child o..."]
website/docs/d/route53_zone.html.markdown:47 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "a pair on the desired Hosted Z..."]
website/docs/r/autoscaling_schedule.html.markdown:58 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `arn` - The ARN assigned by ..."]
website/docs/r/db_option_group.html.markdown:12 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* [MariaDB Options](https://do..."]
website/docs/r/db_parameter_group.html.markdown:12 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* [Aurora MySQL Parameters](ht..."]
website/docs/r/pinpoint_apns_channel.markdown:44 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `certificate` - (Required) T..."]
website/docs/r/pinpoint_apns_channel.markdown:48 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `bundle_id` - (Required) The..."]
website/docs/r/pinpoint_apns_sandbox_channel.markdown:44 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `certificate` - (Required) T..."]
website/docs/r/pinpoint_apns_sandbox_channel.markdown:48 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `bundle_id` - (Required) The..."]
website/docs/r/pinpoint_apns_voip_channel.markdown:44 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `certificate` - (Required) T..."]
website/docs/r/pinpoint_apns_voip_channel.markdown:48 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `bundle_id` - (Required) The..."]
website/docs/r/pinpoint_apns_voip_sandbox_channel.markdown:44 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `certificate` - (Required) T..."]
website/docs/r/pinpoint_apns_voip_sandbox_channel.markdown:48 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `bundle_id` - (Required) The..."]
website/docs/r/s3_bucket.html.markdown:419 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* For a specific rule, `prefix..."]
website/docs/r/sagemaker_endpoint_configuration.html.markdown:51 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `variant_name` - (Optional) ..."]
website/docs/r/spot_datafeed_subscription.html.markdown:30 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* `bucket` - (Required) The Am..."]
website/docs/r/vpc_dhcp_options_association.html.markdown:30 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* You can only associate one D..."]
website/docs/r/vpc_dhcp_options.html.markdown:51 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* Notice that all arguments ar..."]
```
@bflad bflad requested a review from a team February 4, 2020 01:45
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/autoscaling Issues and PRs that pertain to the autoscaling service. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. service/kms Issues and PRs that pertain to the kms service. service/organizations Issues and PRs that pertain to the organizations service. service/pinpoint Issues and PRs that pertain to the pinpoint service. service/rds Issues and PRs that pertain to the rds service. service/route53 Issues and PRs that pertain to the route53 service. service/s3 Issues and PRs that pertain to the s3 service. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Feb 4, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Feb 4, 2020
gdavison
gdavison approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad bflad added this to the v2.48.0 milestone Feb 5, 2020
@bflad bflad merged commit 167c8bb into master Feb 5, 2020
@bflad bflad deleted the t-MD032 branch February 5, 2020 00:09
@ghost
Copy link

ghost commented Feb 7, 2020

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. service/kms Issues and PRs that pertain to the kms service. service/organizations Issues and PRs that pertain to the organizations service. service/pinpoint Issues and PRs that pertain to the pinpoint service. service/rds Issues and PRs that pertain to the rds service. service/route53 Issues and PRs that pertain to the route53 service. service/s3 Issues and PRs that pertain to the s3 service. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.48.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @gdavison