Refactor code_build_project to use keyvaluetags #10701

DrFaust92 · 2019-10-31T21:14:18Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeBuildProject_'

=== RUN   TestAccAWSCodeBuildProject_basic
=== PAUSE TestAccAWSCodeBuildProject_basic
=== CONT  TestAccAWSCodeBuildProject_basic
--- PASS: TestAccAWSCodeBuildProject_basic (57.05s)
=== RUN   TestAccAWSCodeBuildProject_BadgeEnabled
=== PAUSE TestAccAWSCodeBuildProject_BadgeEnabled
=== CONT  TestAccAWSCodeBuildProject_BadgeEnabled
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (59.49s)
=== RUN   TestAccAWSCodeBuildProject_BuildTimeout
=== PAUSE TestAccAWSCodeBuildProject_BuildTimeout
=== CONT  TestAccAWSCodeBuildProject_BuildTimeout
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (87.75s)
=== RUN   TestAccAWSCodeBuildProject_Cache
=== PAUSE TestAccAWSCodeBuildProject_Cache
=== CONT  TestAccAWSCodeBuildProject_Cache
--- FAIL: TestAccAWSCodeBuildProject_Cache (16.62s)
    testing.go:615: Step 1 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-2405352424444994670: EntityAlreadyExists: Role with name tf-acc-test-2405352424444994670 already exists.
        	status code: 409, request id: 7a823ab6-196a-41f6-9b5e-7d79f1a1ccb7
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test197169949\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Description
=== PAUSE TestAccAWSCodeBuildProject_Description
=== CONT  TestAccAWSCodeBuildProject_Description
--- FAIL: TestAccAWSCodeBuildProject_Description (13.63s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-2405352424444994670: EntityAlreadyExists: Role with name tf-acc-test-2405352424444994670 already exists.
        	status code: 409, request id: 4eed3bcc-21a2-4521-9a84-1a6425479ab9
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test182737548\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_EncryptionKey
=== PAUSE TestAccAWSCodeBuildProject_EncryptionKey
=== CONT  TestAccAWSCodeBuildProject_EncryptionKey
--- FAIL: TestAccAWSCodeBuildProject_EncryptionKey (59.62s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-2405352424444994670: EntityAlreadyExists: Role with name tf-acc-test-2405352424444994670 already exists.
        	status code: 409, request id: 4228a6e0-c778-481c-95d2-7cd5205c39c3
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test530292055\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
=== PAUSE TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
=== CONT  TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (111.72s)
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
=== PAUSE TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
=== CONT  TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
--- FAIL: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (15.61s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-2405352424444994670: EntityAlreadyExists: Role with name tf-acc-test-2405352424444994670 already exists.
        	status code: 409, request id: 039cc34e-1510-49fd-9fa3-846e8ca22a24
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test905413680\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Environment_Certificate
=== PAUSE TestAccAWSCodeBuildProject_Environment_Certificate
=== CONT  TestAccAWSCodeBuildProject_Environment_Certificate
--- FAIL: TestAccAWSCodeBuildProject_Environment_Certificate (55.40s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-2405352424444994670: EntityAlreadyExists: Role with name tf-acc-test-2405352424444994670 already exists.
        	status code: 409, request id: 4f1a729f-5dca-415a-8eb2-1f54c62606cb
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test478398414\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
=== PAUSE TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
=== CONT  TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
--- FAIL: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (10.28s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-2405352424444994670: EntityAlreadyExists: Role with name tf-acc-test-2405352424444994670 already exists.
        	status code: 409, request id: f66663fa-1ab6-4582-ab8b-d047f65a9a8a
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test229636090\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_LogsConfig_S3Logs
=== PAUSE TestAccAWSCodeBuildProject_LogsConfig_S3Logs
=== CONT  TestAccAWSCodeBuildProject_LogsConfig_S3Logs
=== RUN   TestAccAWSCodeBuildProject_Source_Auth
=== PAUSE TestAccAWSCodeBuildProject_Source_Auth
=== CONT  TestAccAWSCodeBuildProject_Source_Auth
--- FAIL: TestAccAWSCodeBuildProject_Source_Auth (23.49s)
    testing.go:615: Step 1 error: errors during apply:
        
        Error: Error creating CodeBuild project: InvalidInputException: No Access token found, please visit AWS CodeBuild console to connect to GitHub
        	status code: 400, request id: 63329632-2961-4570-bc7a-ca43478d4cec
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test542179683\main.tf line 64:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Source_GitCloneDepth
=== PAUSE TestAccAWSCodeBuildProject_Source_GitCloneDepth
=== CONT  TestAccAWSCodeBuildProject_Source_GitCloneDepth
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (81.39s)
=== RUN   TestAccAWSCodeBuildProject_Source_InsecureSSL
=== PAUSE TestAccAWSCodeBuildProject_Source_InsecureSSL
=== CONT  TestAccAWSCodeBuildProject_Source_InsecureSSL
--- FAIL: TestAccAWSCodeBuildProject_Source_InsecureSSL (15.12s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-6374215170282504912: EntityAlreadyExists: Role with name tf-acc-test-6374215170282504912 already exists.
        	status code: 409, request id: 79af0e44-5bb1-478a-984b-05abc7cdff0f
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test429506046\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (79.23s)
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
--- FAIL: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (13.86s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-1309488906475573530: EntityAlreadyExists: Role with name tf-acc-test-1309488906475573530 already exists.
        	status code: 409, request id: 749e758d-a4fc-4e85-b61b-3217275f5095
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test202470186\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
--- FAIL: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (14.09s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-1309488906475573530: EntityAlreadyExists: Role with name tf-acc-test-1309488906475573530 already exists.
        	status code: 409, request id: 276114f7-5b7c-44da-b200-32491d5ae927
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test228427576\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Source_Type_Bitbucket
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_Bitbucket
=== CONT  TestAccAWSCodeBuildProject_Source_Type_Bitbucket
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (57.40s)
=== RUN   TestAccAWSCodeBuildProject_Source_Type_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_CodeCommit
=== CONT  TestAccAWSCodeBuildProject_Source_Type_CodeCommit
--- FAIL: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (11.89s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-4647587720189416022: EntityAlreadyExists: Role with name tf-acc-test-4647587720189416022 already exists.
        	status code: 409, request id: 95c14ebf-a5f8-4cd8-a3c9-7dc8abf0cce7
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test213004228\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Source_Type_CodePipeline
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_CodePipeline
=== CONT  TestAccAWSCodeBuildProject_Source_Type_CodePipeline
--- FAIL: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (10.00s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-4647587720189416022: EntityAlreadyExists: Role with name tf-acc-test-4647587720189416022 already exists.
        	status code: 409, request id: 1f0cc912-ef18-484b-9e74-829926809ca8
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test366277551\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
=== CONT  TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
--- FAIL: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (11.71s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-4647587720189416022: EntityAlreadyExists: Role with name tf-acc-test-4647587720189416022 already exists.
        	status code: 409, request id: 75e82521-3d0d-4e1c-8313-b2ca9681eaa9
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test549493404\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Source_Type_S3
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_S3
=== CONT  TestAccAWSCodeBuildProject_Source_Type_S3
--- FAIL: TestAccAWSCodeBuildProject_Source_Type_S3 (58.80s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-4647587720189416022: EntityAlreadyExists: Role with name tf-acc-test-4647587720189416022 already exists.
        	status code: 409, request id: 3bdbd91b-8ec4-4294-9b6b-8b9c247136d8
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test760068391\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Source_Type_NoSource
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_NoSource
=== CONT  TestAccAWSCodeBuildProject_Source_Type_NoSource
--- FAIL: TestAccAWSCodeBuildProject_Source_Type_NoSource (12.13s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-4647587720189416022: EntityAlreadyExists: Role with name tf-acc-test-4647587720189416022 already exists.
        	status code: 409, request id: f7ce7a47-145e-4ebf-9fbe-c7822c90094a
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test361092840\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
=== CONT  TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
--- FAIL: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (13.67s)
    testing.go:608: Step 0, expected error:
        
        errors during apply: Error creating IAM Role tf-acc-test-4647587720189416022: EntityAlreadyExists: Role with name tf-acc-test-4647587720189416022 already exists.
        	status code: 409, request id: 996f743e-bcdb-4781-bdef-2f788e50ae64
        
        To match:
        
        `build_spec` must be set when source's `type` is `NO_SOURCE`
        
        
=== RUN   TestAccAWSCodeBuildProject_Tags
=== PAUSE TestAccAWSCodeBuildProject_Tags
=== CONT  TestAccAWSCodeBuildProject_Tags
--- PASS: TestAccAWSCodeBuildProject_Tags (79.37s)
=== RUN   TestAccAWSCodeBuildProject_VpcConfig
=== PAUSE TestAccAWSCodeBuildProject_VpcConfig
=== CONT  TestAccAWSCodeBuildProject_VpcConfig
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (161.20s)
=== RUN   TestAccAWSCodeBuildProject_WindowsContainer
=== PAUSE TestAccAWSCodeBuildProject_WindowsContainer
=== CONT  TestAccAWSCodeBuildProject_WindowsContainer
--- FAIL: TestAccAWSCodeBuildProject_WindowsContainer (12.04s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-323399904349678830: EntityAlreadyExists: Role with name tf-acc-test-323399904349678830 already exists.
        	status code: 409, request id: daac68a7-c98a-443f-8d81-b0db2b441c6b
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test746867749\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier
=== CONT  TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier
--- FAIL: TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier (14.40s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-323399904349678830: EntityAlreadyExists: Role with name tf-acc-test-323399904349678830 already exists.
        	status code: 409, request id: 83947584-aee7-48c2-b967-f7170ba82515
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test080371771\main.tf line 2:
          (source code not available)
        
        
        
        Error: Error creating S3 bucket: BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.
        	status code: 409, request id: AE501F7BD20A97DF, host id: mit8ElW6IGQt2hcID3fXnGqg2Pdc/Ff2f0VLcyozK5xY/WHeZ2YMU6phGunEl0ASU036DYGXs5Q=
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test080371771\main.tf line 64:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
=== CONT  TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
--- FAIL: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (49.62s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-323399904349678830: EntityAlreadyExists: Role with name tf-acc-test-323399904349678830 already exists.
        	status code: 409, request id: 05c09eca-efad-4860-a4c8-7f2f3f87fb57
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test920740684\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Location
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Location
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Location
--- FAIL: TestAccAWSCodeBuildProject_Artifacts_Location (15.09s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-323399904349678830: EntityAlreadyExists: Role with name tf-acc-test-323399904349678830 already exists.
        	status code: 409, request id: ff9a9fbc-913d-443b-87c6-9e3bea32133e
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test637536408\main.tf line 2:
          (source code not available)
        
        
        
        Error: Error creating S3 bucket: BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.
        	status code: 409, request id: 659E79F35679C609, host id: LxThodBz0x9Td7hq4CT39B57mM9vzaECljrA5SegyY6xptY9Dqz0DGhdNrYnTlUV3tTqsrTu7Ks=
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test637536408\main.tf line 64:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Name
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Name
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Name
--- FAIL: TestAccAWSCodeBuildProject_Artifacts_Name (16.42s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating S3 bucket: BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.
        	status code: 409, request id: 64BF5A148E1938AE, host id: TdEasFqqhn4aKSJYi/6R90+J9BGU5bKcF+I9pKgG0zoGpw2OCiFoekLyatkyM10/w07GdOf6Z6s=
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test118078003\main.tf line 64:
          (source code not available)
        
        
        
        Error: Error creating IAM Role tf-acc-test-323399904349678830: EntityAlreadyExists: Role with name tf-acc-test-323399904349678830 already exists.
        	status code: 409, request id: e6371852-1ce4-4dc3-9b01-2336405099e3
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test118078003\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Artifacts_NamespaceType
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_NamespaceType
=== CONT  TestAccAWSCodeBuildProject_Artifacts_NamespaceType
--- FAIL: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (13.46s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating S3 bucket: BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.
        	status code: 409, request id: 04EBF2EBDD2F1365, host id: 7a4sPSD+88hPaK2/OHHVj6DZchCRlEPsGwDH8uFbygXNfuWj9vt4oLCYVyD+9wVhfQCFpkMfjt8=
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test027389346\main.tf line 64:
          (source code not available)
        
        
        
        Error: Error creating IAM Role tf-acc-test-323399904349678830: EntityAlreadyExists: Role with name tf-acc-test-323399904349678830 already exists.
        	status code: 409, request id: 6b2fd166-3f19-45d6-9d8b-98da4c907660
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test027389346\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
=== CONT  TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
--- FAIL: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (52.43s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-323399904349678830: EntityAlreadyExists: Role with name tf-acc-test-323399904349678830 already exists.
        	status code: 409, request id: e7a2bc91-de32-4d2d-a97b-130f65724bd0
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test007681776\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Packaging
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Packaging
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Packaging
--- FAIL: TestAccAWSCodeBuildProject_Artifacts_Packaging (14.42s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-323399904349678830: EntityAlreadyExists: Role with name tf-acc-test-323399904349678830 already exists.
        	status code: 409, request id: f7201416-3a12-40c1-a4ca-dc2408b6a0ca
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test818366763\main.tf line 2:
          (source code not available)
        
        
        
        Error: Error creating S3 bucket: BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.
        	status code: 409, request id: 87014FD10310F3E1, host id: uUW7GvGsdnHXKVFICQ19GeT8fs+FpO8QuD4h7KDEYhtAvRWZ4JGydDp5tQ2vwUA6dmaCfgtspRU=
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test818366763\main.tf line 64:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Path
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Path
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Path
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (138.44s)
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Type
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Type
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Type
--- FAIL: TestAccAWSCodeBuildProject_Artifacts_Type (14.82s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-2073370750587740800: EntityAlreadyExists: Role with name tf-acc-test-2073370750587740800 already exists.
        	status code: 409, request id: 9f45c7ff-fd62-4a3f-86ae-cb73fcc7e85c
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test895616775\main.tf line 2:
          (source code not available)
        
        
        
        Error: Error creating S3 bucket: BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.
        	status code: 409, request id: 0D41E7D4AF16EA5F, host id: M5DzjYSw9Jp1mHq9R0PP2aRu2UMum6nhrhOWL/gs62z3CSfnwQjVzPFoOc6eW5PZUMiV5Wr8guE=
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test895616775\main.tf line 64:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts
--- FAIL: TestAccAWSCodeBuildProject_SecondaryArtifacts (10.90s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-2073370750587740800: EntityAlreadyExists: Role with name tf-acc-test-2073370750587740800 already exists.
        	status code: 409, request id: bca97f4a-b53d-4712-94dc-46ef23b40f50
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test138584648\main.tf line 2:
          (source code not available)
        
        
        
        Error: Error creating S3 bucket: BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.
        	status code: 409, request id: CA3DD8CF18B52CE8, host id: ITvpRB/NWLdmdtpVC0VjJBwVoIEoShPAGUiv2n2C9F781g8wQ9oWSXa+vheCCFESyEygPVD6cZA=
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test138584648\main.tf line 64:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier
--- FAIL: TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier (14.39s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-2073370750587740800: EntityAlreadyExists: Role with name tf-acc-test-2073370750587740800 already exists.
        	status code: 409, request id: 85cc8239-4abd-464f-859c-db07e2639a04
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test503016486\main.tf line 2:
          (source code not available)
        
        
        
        Error: Error creating S3 bucket: BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.
        	status code: 409, request id: A6AFA2E0224C5B0A, host id: HxF916JkAgAsOk81PHXZbHDFmOGW1hWNachU8ehjRjsiTIosUuRPtcO1vDEEuD19hfCC+aFu4iA=
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test503016486\main.tf line 64:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName
--- FAIL: TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName (14.35s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-2073370750587740800: EntityAlreadyExists: Role with name tf-acc-test-2073370750587740800 already exists.
        	status code: 409, request id: 601975cf-8608-4290-b0e2-f0d434d958e4
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test905925076\main.tf line 2:
          (source code not available)
        
        
        
        Error: Error creating S3 bucket: BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.
        	status code: 409, request id: 483970AD53518B20, host id: yF8BPkbxDElb7MXfb0yjAKK5aXymbA4L1tx9BTDVjP8H0JL2Kzua8qsFLqH+Q4Y7fuZeJwXNX7I=
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test905925076\main.tf line 64:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled
--- FAIL: TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled (14.06s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating S3 bucket: BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.
        	status code: 409, request id: 5A2D8ACAD383202A, host id: 1il7g0qau2tswC03/Z+tB9r5OoVNm4RWDy4BKbKYtFYgCu/Tgcm8Fj79cpaSUzAxDqb6DIIQLIY=
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test818470921\main.tf line 64:
          (source code not available)
        
        
        
        Error: Error creating IAM Role tf-acc-test-2073370750587740800: EntityAlreadyExists: Role with name tf-acc-test-2073370750587740800 already exists.
        	status code: 409, request id: bf374442-1831-43fe-9e2a-87198546dd4f
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test818470921\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Location
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Location
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Location
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Location (152.49s)
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Name
--- SKIP: TestAccAWSCodeBuildProject_SecondaryArtifacts_Name (0.00s)
    resource_aws_codebuild_project_test.go:1507: Currently no solution to allow updates on name attribute

Test ignored.
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType
--- FAIL: TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType (13.97s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-6193492801107490263: EntityAlreadyExists: Role with name tf-acc-test-6193492801107490263 already exists.
        	status code: 409, request id: 24f8254b-2367-408e-9c79-d8e88be4f3cf
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test687150782\main.tf line 2:
          (source code not available)
        
        
        
        Error: Error creating S3 bucket: BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.
        	status code: 409, request id: CCBF67F1B6E39DA1, host id: y0KZWXvZL8/nIcoS2l9IYzSINm3TYYNfLgcYkWZSLhnXNMrl2QhCaIwOabZ/4lnMEjZ7ntIfH/k=
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test687150782\main.tf line 64:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging
--- FAIL: TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging (14.51s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-6193492801107490263: EntityAlreadyExists: Role with name tf-acc-test-6193492801107490263 already exists.
        	status code: 409, request id: e94af59d-b397-46ea-8bf6-604c521d325e
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test510924353\main.tf line 2:
          (source code not available)
        
        
        
        Error: Error creating S3 bucket: BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.
        	status code: 409, request id: 6E519E2F4A7F2BAB, host id: a99G+oNjoO9It+oEH5kyrPJ7Nm9iiq0yELbPp+eJYksA5mSfcTvgur1QlKKRvLU0NCSRa4a9zdU=
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test510924353\main.tf line 64:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Path
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Path
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Path
--- FAIL: TestAccAWSCodeBuildProject_SecondaryArtifacts_Path (44.35s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-6193492801107490263: EntityAlreadyExists: Role with name tf-acc-test-6193492801107490263 already exists.
        	status code: 409, request id: 54356dbb-7ac5-465d-8eb3-38921f72da34
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test941014506\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts_Type
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts_Type
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts_Type
--- FAIL: TestAccAWSCodeBuildProject_SecondaryArtifacts_Type (46.42s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-6193492801107490263: EntityAlreadyExists: Role with name tf-acc-test-6193492801107490263 already exists.
        	status code: 409, request id: 7c7eccb7-62e2-4a73-a8b6-91758718c192
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test198232578\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
=== CONT  TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
--- FAIL: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (14.51s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating IAM Role tf-acc-test-6193492801107490263: EntityAlreadyExists: Role with name tf-acc-test-6193492801107490263 already exists.
        	status code: 409, request id: ef0c2436-fe31-4434-a055-53e27b7c8a99
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test272039691\main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccAWSCodeBuildProject_Environment_RegistryCredential
=== PAUSE TestAccAWSCodeBuildProject_Environment_RegistryCredential
=== CONT  TestAccAWSCodeBuildProject_Environment_RegistryCredential
--- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (94.22s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (188.77s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	573.725s

...

some tests seem to fail because they try to create the same resource at the same time but it seems that the most relevant tests seem to pass

merge

add update tags to use keyvaluetags delete create tags conditional

bflad

LGTM, thanks @DrFaust92 🚀

Output from acceptance testing (failure unrelated):

--- FAIL: TestAccAWSCodeBuildProject_Source_Auth (13.49s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (38.27s)
--- PASS: TestAccAWSCodeBuildProject_basic (38.19s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (39.78s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (41.42s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (41.70s)
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (41.71s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (34.23s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (51.64s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (51.58s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (52.77s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (53.02s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (53.02s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (53.18s)
--- PASS: TestAccAWSCodeBuildProject_Description (54.12s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (54.36s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (57.44s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (58.29s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (19.16s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (63.05s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (63.43s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (30.84s)
--- SKIP: TestAccAWSCodeBuildProject_SecondaryArtifacts_Name (0.00s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (33.54s)
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (31.92s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier (30.07s)
--- PASS: TestAccAWSCodeBuildProject_Tags (42.74s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Location (35.90s)
--- PASS: TestAWSCodeBuildProject_nameValidation (0.00s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (33.51s)
--- PASS: TestAccAWSCodeBuildProject_Cache (91.27s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (47.09s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Name (46.26s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Packaging (46.90s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Type (46.24s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (46.87s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (48.23s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (47.90s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (59.50s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier (43.39s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName (43.98s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled (42.45s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Location (42.90s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Type (30.71s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (23.96s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType (41.06s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging (38.87s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Path (37.74s)
--- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (36.86s)

ghost · 2019-11-07T21:58:56Z

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-03-29T17:27:55Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

DrFaust92 and others added 4 commits October 26, 2019 18:06

Merge pull request #5 from terraform-providers/master

c0f6d5e

merge

Merge pull request #6 from terraform-providers/master

07ddc49

merge

use keyvaluetags for codebuild

2dae6fc

remove codebuild tagsCodeBuild.go

748b9d2

add update tags to use keyvaluetags delete create tags conditional

DrFaust92 requested a review from a team October 31, 2019 21:14

ghost added size/S Managed by automation to categorize the size of a PR. service/codebuild Issues and PRs that pertain to the codebuild service. labels Oct 31, 2019

use enum for exception

8f8c4d3

bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 4, 2019

bflad added this to the v2.35.0 milestone Nov 4, 2019

bflad approved these changes Nov 4, 2019

View reviewed changes

bflad merged commit 2a08ad7 into hashicorp:master Nov 4, 2019

DrFaust92 deleted the refactor-codebuild-keyvaluetags branch November 9, 2019 12:40

ghost locked and limited conversation to collaborators Mar 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor code_build_project to use keyvaluetags #10701

Refactor code_build_project to use keyvaluetags #10701

DrFaust92 commented Oct 31, 2019 •

edited

Loading

bflad left a comment

ghost commented Nov 7, 2019

ghost commented Mar 29, 2020

Refactor code_build_project to use keyvaluetags #10701

Refactor code_build_project to use keyvaluetags #10701

Conversation

DrFaust92 commented Oct 31, 2019 • edited Loading

Community Note

bflad left a comment

Choose a reason for hiding this comment

ghost commented Nov 7, 2019

ghost commented Mar 29, 2020

DrFaust92 commented Oct 31, 2019 •

edited

Loading