Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iotevents service regex #10593

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Add iotevents service regex #10593

merged 1 commit into from
Nov 4, 2019

Conversation

oleksiyVeretiuk
Copy link
Contributor

@oleksiyVeretiuk oleksiyVeretiuk commented Oct 22, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #10591

Release note for CHANGELOG:

Update .hashibot.hcl with iotevents service

@oleksiyVeretiuk oleksiyVeretiuk requested a review from a team October 22, 2019 07:56
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Oct 22, 2019
@oleksiyVeretiuk oleksiyVeretiuk force-pushed the add_iotevents_in_hashibothcl branch from f2da467 to d9a6e4a Compare October 22, 2019 13:09
@oleksiyVeretiuk oleksiyVeretiuk changed the title Add iotanalytics service regex Add iotevents service regex Oct 22, 2019
@oleksiyVeretiuk oleksiyVeretiuk force-pushed the add_iotevents_in_hashibothcl branch from d9a6e4a to 379580a Compare October 22, 2019 13:26
@oleksiyVeretiuk
Copy link
Contributor Author

There is an connection error on travis

fatal: unable to access 'https://github.com/hashicorp/terraform-website/': Failed to connect to github.com port 443: Connection timed out

Can somebody restart it later?

bflad
bflad approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @oleksiyVeretiuk 🚀 Will pull in #10593 and #10594 together to resolve any potential merge conflicts.

bflad added a commit that referenced this pull request Nov 4, 2019
@bflad
provider: Merge related #10593 and #10594 additions for iotanalytics …
4b640c0 
…and iotevents labeling
@bflad bflad merged commit 379580a into hashicorp:master Nov 4, 2019
@bflad bflad added this to the v2.35.0 milestone Nov 4, 2019
@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.35.0
Development

Successfully merging this pull request may close these issues.

Add iotevents regex to .hashibot.hcl
2 participants
@oleksiyVeretiuk @bflad