tests/resource/aws_cloudfront_distribution: BucketNotEmpty Errors

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The following testing is showing errors related non-empty S3 Buckets:

=== CONT  TestAccAWSCloudFrontDistribution_originPolicyOrdered
testing_new.go:63: Error running post-test destroy, there may be dangling resources: exit status 1
Error: error deleting S3 Bucket (mylogs.2357952446407137479): BucketNotEmpty: The bucket you tried to delete is not empty
  status code: 409, request id: MPKM026WH6589YVB, host id: lht+Qof4FYrYfdN/8GtjzeaAjoOsZ6aj69agmshQhUJyxNMoFnU6K6cLGU8eR53nV9e4q8nD0H8=
--- FAIL: TestAccAWSCloudFrontDistribution_originPolicyOrdered (343.36s)

=== CONT  TestAccAWSCloudFrontDistribution_S3Origin
testing_new.go:63: Error running post-test destroy, there may be dangling resources: exit status 1
Error: error deleting S3 Bucket (mylogs.3372655815263830900): BucketNotEmpty: The bucket you tried to delete is not empty
  status code: 409, request id: XE65MK42EWF6Y4CN, host id: Lrn6YBKiBDwkzn+ge4i7QHa5kzaZOazWHAG899H7tzWpWQoLutfr1VM3HoSPXPGihNvEfRYsmJ8=
--- FAIL: TestAccAWSCloudFrontDistribution_S3Origin (405.80s)

=== CONT  TestAccAWSCloudFrontDistribution_multiOrigin
testing_new.go:63: Error running post-test destroy, there may be dangling resources: exit status 1
Error: error deleting S3 Bucket (mylogs.3276133232211037586): BucketNotEmpty: The bucket you tried to delete is not empty
  status code: 409, request id: XE64PFJ4MXABGV9D, host id: iV0ph9Kutj5Sjb+lGfulrXTh/HMowzHzHwtjG1+h9leJ1uvnDFIxA6ZCwe1BJJrH3h4UU0TAxb4=
--- FAIL: TestAccAWSCloudFrontDistribution_multiOrigin (377.78s)

=== CONT  TestAccAWSCloudFrontDistribution_customOrigin
testing_new.go:63: Error running post-test destroy, there may be dangling resources: exit status 1
Error: error deleting S3 Bucket (mylogs.513520244091798268): BucketNotEmpty: The bucket you tried to delete is not empty
  status code: 409, request id: 96KBJSB2W4DTE8XQ, host id: irsAvk26kB0RehhtFu2kfYz7gOZGNrGVgwy2PRhZlRagE9cgePqsN75xJ64M2/WXB26Il7VHPak=
--- FAIL: TestAccAWSCloudFrontDistribution_customOrigin (399.82s)

=== CONT  TestAccAWSCloudFrontDistribution_originPolicyDefault
testing_new.go:63: Error running post-test destroy, there may be dangling resources: exit status 1
Error: error deleting S3 Bucket (mylogs.7021845477121765752): BucketNotEmpty: The bucket you tried to delete is not empty
  status code: 409, request id: 96K02Y0K8CYDH6SS, host id: /jR8/SGpMVR8T+mApYmB66cqcoJqgxPYeMvUYDUthRvlonhGj5PVIsF2MdWRRKXSBc/IsLNd4WU=
--- FAIL: TestAccAWSCloudFrontDistribution_originPolicyDefault (386.06s)

Since the objects in the S3 Bucket are outside the control of the Terraform configuration, it is expected to enable force_destroy = true on these aws_s3_bucket managed resources for this testing. While we are adjusting this configuration, it is probably best to also set the ACL to private.

Affected Resource

• aws_cloudfront_distribution

Potential Terraform Configuration

Quickest fix:

resource "aws_s3_bucket" "s3_bucket_logs" {
  acl           = "public-read"
  bucket        = "mylogs.${var.rand_id}"
  force_destroy = true
}

[ghost]

This has been released in version 3.33.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!