Skip to content

Commit

Permalink
Ignore errors for GetBucketLifecycleConfiguration and GetBucketReplic…
Browse files Browse the repository at this point in the history
…ation

To better support 3rd party S3 storage systems which may not implement these capabilities (such as EMC ECS). Potentially resolves GitHub Issues: #23291 (comment)
  • Loading branch information
absa-rsuarez authored and jar-b committed Feb 10, 2023
1 parent 5848ccf commit ef485cb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions internal/service/s3/bucket.go
Original file line number Diff line number Diff line change
Expand Up @@ -1223,7 +1223,7 @@ func resourceBucketRead(ctx context.Context, d *schema.ResourceData, meta interf
return diags
}

if err != nil && !tfawserr.ErrCodeEquals(err, ErrCodeNoSuchLifecycleConfiguration) {
if err != nil && !tfawserr.ErrCodeEquals(err, ErrCodeNoSuchLifecycleConfiguration, ErrCodeNotImplemented) {
return sdkdiag.AppendErrorf(diags, "getting S3 Bucket (%s) Lifecycle Configuration: %s", d.Id(), err)
}

Expand Down Expand Up @@ -1252,7 +1252,7 @@ func resourceBucketRead(ctx context.Context, d *schema.ResourceData, meta interf
return diags
}

if err != nil && !tfawserr.ErrCodeEquals(err, ErrCodeReplicationConfigurationNotFound) {
if err != nil && !tfawserr.ErrCodeEquals(err, ErrCodeReplicationConfigurationNotFound, ErrCodeNotImplemented) {
return sdkdiag.AppendErrorf(diags, "getting S3 Bucket replication: %s", err)
}

Expand Down

0 comments on commit ef485cb

Please sign in to comment.