Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tests/resource/aws_sns_topic_subscription: Fix Terraform 0.12 syntax
These changes are backwards compatible with Terraform 0.11. The remaining configuration error requires this upstream issue: hashicorp/terraform#20098 Previous output from Terraform 0.12 acceptance testing: ``` --- FAIL: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (0.44s) testing.go:568: Step 0 error: /opt/teamcity-agent/temp/buildTmp/tf-test250105636/main.tf:25,5-6: Invalid argument name; Argument names must not be quoted. --- FAIL: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (0.60s) testing.go:568: Step 0 error: /opt/teamcity-agent/temp/buildTmp/tf-test092280804/main.tf:26,5-6: Invalid argument name; Argument names must not be quoted. ``` Output from Terraform 0.12 acceptance testing (additional fixes required upstream in Terraform Provider SDK): ``` --- FAIL: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (1.70s) testing.go:568: Step 0 error: config is invalid: Error in function call: Call to function "file" failed: contents of test-fixtures/lambda_confirm_sns.zip are not valid UTF-8; to read arbitrary bytes, use the filebase64 function instead. --- FAIL: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (1.70s) testing.go:568: Step 0 error: config is invalid: 2 problems: - Error in function call: Call to function "file" failed: contents of test-fixtures/lambda_confirm_sns.zip are not valid UTF-8; to read arbitrary bytes, use the filebase64 function instead. - Error in function call: Call to function "file" failed: contents of test-fixtures/lambda_basic_authorizer.zip are not valid UTF-8; to read arbitrary bytes, use the filebase64 function instead. ```
- Loading branch information