Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Additional type-based semantic equality information #769

Merged
merged 1 commit into from
Jun 14, 2023
Merged

docs: Additional type-based semantic equality information #769

merged 1 commit into from
Jun 14, 2023

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 13, 2023

Per out-of-band feedback:

  • Add mentions of custom types into SDK migration documentation for attribute fields
  • Add mention in custom type semantic equality section about framework automatic collection/object behaviors with element/underlying attribute types.

@bflad
docs: Additional type-based semantic equality information
bd95c5d 
Per out-of-band feedback:

- Add mentions of custom types into SDK migration documentation for attribute fields
- Add mention in custom type semantic equality section about framework automatic collection/object behaviors with element/underlying attribute types.
@bflad bflad added the documentation Improvements or additions to documentation label Jun 13, 2023
@bflad bflad added this to the v1.3.1 milestone Jun 13, 2023
@bflad bflad requested a review from a team as a code owner June 13, 2023 20:11
austinvalle
austinvalle approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@bflad bflad merged commit 8f82483 into main Jun 14, 2023
@bflad bflad deleted the bflad/semantic-equality-docs-mentions branch June 14, 2023 14:58
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@austinvalle austinvalle austinvalle approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @austinvalle