Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTEL instrumentation #1327

Merged
merged 1 commit into from
Jul 28, 2023
Merged

OTEL instrumentation #1327

merged 1 commit into from
Jul 28, 2023

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jul 11, 2023 •
edited
Loading

Related to #1056

Example trace

Screenshot 2023-07-18 at 13 57 49

Screenshot 2023-07-18 at 14 53 44

Later TODO

@radeksimko radeksimko added enhancement New feature or request performance Gotta go fast labels Jul 11, 2023
@radeksimko radeksimko force-pushed the f-opentelemetry-instrumentation branch 25 times, most recently from ed66ae7 to c12f791 Compare July 18, 2023 12:43
@radeksimko radeksimko force-pushed the f-opentelemetry-instrumentation branch 3 times, most recently from 0aaebfc to 03e034d Compare July 21, 2023 10:46
@radeksimko radeksimko force-pushed the f-opentelemetry-instrumentation branch 7 times, most recently from f22185f to 62935b2 Compare July 26, 2023 12:56
@radeksimko radeksimko force-pushed the f-opentelemetry-instrumentation branch from 62935b2 to f9b49cf Compare July 26, 2023 12:59
@radeksimko radeksimko marked this pull request as ready for review July 26, 2023 12:59
@radeksimko radeksimko requested a review from a team as a code owner July 26, 2023 12:59
dbanck
dbanck approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Re-tested it with the f-otel-honeycomb branch

@radeksimko radeksimko merged commit b9eabdc into main Jul 28, 2023
@radeksimko radeksimko deleted the f-opentelemetry-instrumentation branch July 28, 2023 05:48
This was referenced Jul 28, 2023
Open
Merged
Merged
Open
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request performance Gotta go fast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @dbanck