Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): support HTTP_PROXY for Terraform Cloud #1507

Merged
merged 3 commits into from
Mar 31, 2022
Merged

feat(cli): support HTTP_PROXY for Terraform Cloud #1507

merged 3 commits into from
Mar 31, 2022

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Jan 25, 2022 •
edited by ansgarm
Loading

Closes #816

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ansgarm ansgarm marked this pull request as ready for review March 30, 2022 11:47
DanielMSchmidt
DanielMSchmidt commented Mar 31, 2022
View reviewed changes
Copy link
Contributor Author

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Great work @ansgarm

packages/cdktf-cli/lib/models/terraform-cloud.ts Show resolved Hide resolved
test/typescript/providers/test.ts Show resolved Hide resolved
test/typescript/terraform-cloud/test.ts Show resolved Hide resolved
@ansgarm ansgarm merged commit 2c6df1f into main Mar 31, 2022
@ansgarm ansgarm deleted the proxy-env branch March 31, 2022 13:25
@DanielMSchmidt DanielMSchmidt mentioned this pull request Apr 1, 2022
Merged
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ansgarm ansgarm ansgarm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support HTTP_PROXY/HTTPS_PROXY for Terraform Cloud
4 participants
@DanielMSchmidt @hashicorp-cla @ansgarm @skorfmann