Support patching an ARM template. #3665
Conversation
| @@ -9,6 +9,7 @@ import ( | |||
| "github.com/mitchellh/packer/builder/azure/common/approvals" | |||
| "github.com/mitchellh/packer/builder/azure/common/constants" | |||
| "github.com/mitchellh/packer/builder/azure/common/template" | |||
| "io/ioutil" | |||
| "golang.org/x/crypto/ssh" | ||
| "os" |
|
Should we also update documentation on the website? |
| return err | ||
| } | ||
|
|
||
| c.armTemplatePatch = &patch |
There was a problem hiding this comment.
No reason to take the address of patch, it's a slice Type.
boumenot
force-pushed
the
pr-template-patching
branch
from
7bab2ee to
9fc1765
Compare
azure: Support for a user defined VNET.
Patching support is based on RFC 6902. Users have the ability to patch the ARM virtual machine template before it is submitted to Azure for processing. Add a dependency on evanphx/json-patch to support JSON patching.
boumenot
force-pushed
the
pr-template-patching
branch
from
9fc1765 to
ccd10ae
Compare
|
Looks like this needs a rebase...? @boumenot |
|
@boumenot I will happily review your P.R. or whatever work is needed to get this pushed out. Let me know how I can help. |
|
I think we should just focus on having plan information added and make this simpler, take plan information as an additional optional filed and then pass this along on the VM create operation. In addition would should also tag the image with the plan information so that its available for the users who would need to use the custom image. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Patching support is based on RFC 6902. Users have the ability to patch
the ARM virtual machine template before it is submitted to Azure for
processing.
Add a dependency on evanphx/json-patch to support JSON patching.
Closes #3506