-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WTDD: Update UI api docs #9690
WTDD: Update UI api docs #9690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whew, so much new material! I wonder if we can embed this in the code somehow in the future 🤔
I made a couple of spelling fix suggestions and maybe page
has the wrong default but otherwise 👍😀
website/pages/api-docs/ui.mdx
Outdated
- `search` `(string: "")` - Specifies a regular expression used to filter the list of | ||
visible allocations. This is specified as a query string parameter. | ||
|
||
- `page` `(int: 0)` - Specifies the page in the allocations list that should be visible. This |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a default of 1
I think? 😯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this preexists elsewhere, maybe a global fix is warranted 🧐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on this; I can update it throughout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
total success 🥳
or not, I see there’s a merge conflict now 😞 |
I expected the merge conflicts. The |
0.7 is ancient at this point. Now it's as if the UI has always existed.
Co-authored-by: Buck Doyle <[email protected]>
24c9dc3
to
590e7ca
Compare
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
These were very out of date, lol.