Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WTDD: Update UI api docs #9690

Merged
merged 7 commits into from
Jan 7, 2021
Merged

Conversation

DingoEatingFuzz
Copy link
Contributor

These were very out of date, lol.

@DingoEatingFuzz DingoEatingFuzz added the theme/docs Documentation issues and enhancements label Dec 18, 2020
Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whew, so much new material! I wonder if we can embed this in the code somehow in the future 🤔

I made a couple of spelling fix suggestions and maybe page has the wrong default but otherwise 👍😀

- `search` `(string: "")` - Specifies a regular expression used to filter the list of
visible allocations. This is specified as a query string parameter.

- `page` `(int: 0)` - Specifies the page in the allocations list that should be visible. This
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a default of 1 I think? 😯

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this preexists elsewhere, maybe a global fix is warranted 🧐

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on this; I can update it throughout.

Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

total success 🥳

@backspace
Copy link
Contributor

or not, I see there’s a merge conflict now 😞

@DingoEatingFuzz
Copy link
Contributor Author

I expected the merge conflicts. The next-mdx-remote migration merged yesterday. I'll get on the rebase.

@DingoEatingFuzz DingoEatingFuzz force-pushed the docs-wtdd-update-ui-api-docs branch from 24c9dc3 to 590e7ca Compare January 7, 2021 18:00
@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui January 7, 2021 18:00 Inactive
@DingoEatingFuzz DingoEatingFuzz merged commit aba38e4 into master Jan 7, 2021
@DingoEatingFuzz DingoEatingFuzz deleted the docs-wtdd-update-ui-api-docs branch January 7, 2021 18:52
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/docs Documentation issues and enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants