scripts: fail if golang installation fails #9567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 8, 2020 09:59
So this matches the Vagrant box
Namely ensure the script fails if any step fails, only skip installing if that particular version is installed, and retry if the download fails
tgross
approved these changes
Dec 8, 2020
| @@ -2,7 +2,7 @@ | |||
| # that mimics Vagrant environment as far as required | |||
| # for building the scripts and running provision scripts | |||
|
|
|||
| FROM ubuntu:16.04 | |||
| FROM ubuntu:18.04 | |||
There was a problem hiding this comment.
Good call on keeping it here till we do more testing... some 20.04 setups have a lot of quirks with snaps that we might want to be aware of before we go charging in.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes few changes to golang installation scripts: ensure that the script fails if any step fails, retry downloading if the download fails.
Also, update our release docker container image to use 18.04, so it matches our Vagrant box. We ought to upgrade both to 20.04 but punting on for now that until I can test the Vagrant box.