Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: fail if golang installation fails #9567

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Dec 8, 2020

This makes few changes to golang installation scripts: ensure that the script fails if any step fails, retry downloading if the download fails.

Also, update our release docker container image to use 18.04, so it matches our Vagrant box. We ought to upgrade both to 20.04 but punting on for now that until I can test the Vagrant box.

Mahmood Ali added 2 commits December 8, 2020 09:59
So this matches the Vagrant box
Namely ensure the script fails if any step fails, only skip installing
if that particular version is installed, and retry if the download fails
@notnoop notnoop requested a review from tgross December 8, 2020 15:15
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2,7 +2,7 @@
# that mimics Vagrant environment as far as required
# for building the scripts and running provision scripts

FROM ubuntu:16.04
FROM ubuntu:18.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on keeping it here till we do more testing... some 20.04 setups have a lot of quirks with snaps that we might want to be aware of before we go charging in.

@notnoop notnoop merged commit 9a112af into master Dec 16, 2020
@notnoop notnoop deleted the scripts-fail-on-golang-failure branch December 16, 2020 15:04
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants