Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: show distinct_hosts constraint for CSI plugins #9052

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

tgross
Copy link
Member

@tgross tgross commented Oct 8, 2020

CSI plugins with the same plugin ID and type (controller, node, monolith) will collide on a host, both in the communication socket and in the dynamic plugin registry. Until this can be fixed, leave notice to operators in the documentation.

Related to #8628. That issue probably isn't going to be fixed before 0.13's beta, so updating the documentation in the meantime.

@tgross tgross requested review from notnoop and drewbailey October 8, 2020 20:30
Copy link
Contributor

@drewbailey drewbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, not sure if the level of warning warrants a note up above or not

CSI plugins with the same plugin ID and type (controller, node, monolith) will
collide on a host, both in the communication socket and in the dynamic plugin
registry. Until this can be fixed, leave notice to operators in the
documentation.
@tgross tgross merged commit 0fcca28 into master Oct 8, 2020
@tgross tgross deleted the docs-csi-plugin-constraints branch October 8, 2020 20:55
@tgross
Copy link
Member Author

tgross commented Oct 8, 2020

cc @angrycub @davemay99 : I'm going to add this to my pile of downstream enablement docs that I'll be working on next week, but this is a potential CSI gotcha.

@angrycub
Copy link
Contributor

angrycub commented Oct 8, 2020

That's a good note. Thanks for adding it!

fredrikhgrelland pushed a commit to fredrikhgrelland/nomad that referenced this pull request Oct 22, 2020
CSI plugins with the same plugin ID and type (controller, node, monolith) will
collide on a host, both in the communication socket and in the dynamic plugin
registry. Until this can be fixed, leave notice to operators in the
documentation.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants