UI: Restore proxy tag tests #6360
Conversation
These are surely still intermittently failing on CircleCI, but I’ll use this PR to hopefully finally determine why and fix it.
Since adding Percy, the proxy tag tests have yet to fail 🤔
I got a failure after a few attempts without it, maybe I just didn’t try enough with?
It appears the problem is that despite my attempts to force the first task in the list to be the one with the tag so it can be asserted against, it’s not always the first. So this should make every task be of kind proxy, so asserting against the first will work.
That seems to have fixed things… 🤞🏻
|
I think this is a once-and-for-all solution to this intermittent failure, finally. I had thought the way I wrote the setup to the allocation detail proxy tag test would guarantee that the first task in the list was the one with the proxy tag, so the assertion on
This explanation is backed up by the fact that this failure that led me to remove these tests yet again happened only in the allocation detail tests and not the test that looks for the proxy tag in a task’s header. Since the number of tasks is dynamic, rather than try to change the factories to ensure there’s only one, this changes all the tasks to have the correct I’ve pushed many empty commits to repeat the tests with different random scenarios and it hasn’t failed since, so hopefully this means total success! |
| const task = server.schema.tasks.findBy({ name: taskState.name }); | ||
| task.update('kind', 'connect-proxy:task'); | ||
| task.save(); | ||
| }); |
There was a problem hiding this comment.
I'm cool with this, but it seems like the thing that was biting you is that the tasks table is sorted alphabetically by task name. So if you wanted to stick with the original plan of only having one task be the proxy, you could mimic the sort by name behavior.
Your call!
There was a problem hiding this comment.
You’re right, I got lazy after the struggle to understand what was happening. I’ve changed it to sort by name, thanks!
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
These are surely still intermittently failing on CircleCI,
but I’ll use this PR to hopefully finally determine why and
fix it.