UI: Fix Connect proxy tag #6343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I put this property in the wrong place. I’ve been unable to properly update the tests that verify the presence of the proxy tag, sadly. The changes I make to models in Mirage aren’t being reflected in the mock API responses. So I’ve skipped the relevant tests for now.
# Conflicts: # ui/tests/acceptance/allocation-detail-test.js
# Conflicts: # ui/tests/acceptance/allocation-detail-test.js
DingoEatingFuzz
approved these changes
Sep 18, 2019
|
hmm yeah, there might be a blessed Ember Data way to wire these things up, I’ll look into it a bit 🤔 |
backspace
added a commit
that referenced
this pull request
Sep 20, 2019
I thought #6343 would fix the flapping but it didn’t 😞
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6307. There’s no direct Ember Data-style relationship between a
TaskStateand itsTask; instead, it’s determined by searching for aTaskwith the matchingname. There was a race condition where the relatedTaskwas sometimes stored before everything was ready and not recalculated when thenamewas known. This ensures the relationship is accurate if theTaskState’snamechanges.