Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add warnings about backing up keyring to snapshot commands #19400

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

tgross
Copy link
Member

@tgross tgross commented Dec 8, 2023

The operator snapshot commands and agent don't back up Nomad's key material. Add some warnings about this to places where users might be looking for information on cluster recovery.

Fixes: #19389
cc @sofixa

The `operator snapshot` commands and agent don't back up Nomad's key
material. Add some warnings about this to places where users might be looking
for information on cluster recovery.

Fixes: #19389
@tgross tgross requested review from lgfa29 and gulducat December 8, 2023 20:29
@tgross tgross added theme/docs Documentation issues and enhancements theme/keyring labels Dec 8, 2023
@tgross tgross added this to the 1.7.x milestone Dec 8, 2023
@tgross tgross added backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line labels Dec 8, 2023
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hope it's "louder" enough!

@tgross tgross merged commit e551814 into main Dec 8, 2023
@tgross tgross deleted the docs-backup-your-keyring branch December 8, 2023 21:05
tgross added a commit that referenced this pull request Dec 8, 2023
)

The `operator snapshot` commands and agent don't back up Nomad's key
material. Add some warnings about this to places where users might be looking
for information on cluster recovery.

Fixes: #19389
tgross added a commit that referenced this pull request Dec 8, 2023
)

The `operator snapshot` commands and agent don't back up Nomad's key
material. Add some warnings about this to places where users might be looking
for information on cluster recovery.

Fixes: #19389
tgross added a commit that referenced this pull request Dec 8, 2023
)

The `operator snapshot` commands and agent don't back up Nomad's key
material. Add some warnings about this to places where users might be looking
for information on cluster recovery.

Fixes: #19389
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line theme/docs Documentation issues and enhancements theme/keyring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add more prominent warnings around backing up keyring
2 participants