Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of client: ignore restart issued to terminal allocations into release/1.4.x #17210

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #17175 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


This PR fixes a bug where issuing a restart to a terminal allocation
would cause the allocation to run its hooks anyway. This was particularly
apparent with group_service_hook who would then register services but
then never deregister them - as the allocation would be effectively in
a "zombie" state where it is prepped to run tasks but never will.

Part of #17079
Part of #16238
Part of #14618
Part of #17182
Part of #16762

Note this doesn't appear to be the only source of leaked registrations - see #17079 for more.

@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 33ee939 into release/1.4.x May 16, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/alloc-restart-zombie/definitely-aware-cougar branch from 0d38c33 to 94d668b Compare May 16, 2023 15:20
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/alloc-restart-zombie/definitely-aware-cougar branch May 16, 2023 15:20
@vercel vercel bot temporarily deployed to Preview – nomad May 16, 2023 15:23 Inactive
Copy link

github-actions bot commented Mar 7, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants