E2E: test exercising node drain behavior for CSI volumes #12384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
e2e-csi-node-drain
branch
from
29a75a3 to
5460040
Compare
tgross
force-pushed
the
e2e-csi-node-drain
branch
from
5460040 to
12d2462
Compare
tgross
force-pushed
the
e2e-csi-node-drain
branch
from
12d2462 to
7a7e23a
Compare
lgfa29
approved these changes
Mar 29, 2022
tgross
force-pushed
the
e2e-csi-node-drain
branch
from
55b1f2e to
01c4d60
Compare
tgross
commented
Mar 29, 2022
| @@ -7,22 +7,22 @@ plan: | |||
| terraform plan \ | |||
| -var="nomad_local_binary=$(PKG_PATH)" \ | |||
| -var="volumes=false" \ | |||
| -var="client_count_ubuntu_bionic_amd64=2" \ | |||
| -var="client_count_ubuntu_bionic_amd64=3" \ | |||
There was a problem hiding this comment.
We have a lot of E2E tests that need at least 3 nodes, including this one, so I've bumped the default here.
This was referenced Apr 20, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run a test on nightly that drains a node and ensures that the CSI volume is moved as expected. (This is still using the "framework-style" testing because I didn't want to rewrite the entire
e2e/csipackage just to land this. Will do that in a follow-up PR.)