Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consul will support envoy 1.14.4 with Consul 1.8 #7665

Closed
hanshasselberg opened this issue Apr 9, 2020 · 5 comments
Closed

Consul will support envoy 1.14.4 with Consul 1.8 #7665

hanshasselberg opened this issue Apr 9, 2020 · 5 comments
Assignees
@shoenig
Labels
theme/consul/connect Consul Connect integration type/enhancement

Comments

@hanshasselberg
Copy link
Member

See hashicorp/consul#7624.

There is also another releated issue: #7111
@hanshasselberg hanshasselberg mentioned this issue Apr 9, 2020
Merged
11 tasks
@jrasell jrasell added theme/consul/connect Consul Connect integration type/enhancement labels Apr 9, 2020
@jrasell
Copy link
Member

jrasell commented Apr 9, 2020

thanks for thinking of us @i0rek :D

@shoenig shoenig self-assigned this Apr 9, 2020
@hanshasselberg
Copy link
Member Author

New versions are out, Consul will support 1.14.2: hashicorp/consul#8057.

@hanshasselberg hanshasselberg mentioned this issue Jun 9, 2020
Merged
11 tasks
@hanshasselberg hanshasselberg mentioned this issue Jun 30, 2020
Merged
14 tasks
@hanshasselberg
Copy link
Member Author

hanshasselberg commented Jul 3, 2020 •
edited by rboyer
Loading

New versions are out, consul will support 1.14.4: hashicorp/consul#8216.

@rboyer rboyer changed the title Consul will support envoy 1.14.1 with Consul 1.8 Consul will support envoy 1.14.4 with Consul 1.8 Jul 9, 2020
shoenig added a commit that referenced this issue Sep 16, 2020
@shoenig
consul/connect: dynamically select envoy sidecar at runtime
8f899ed 
As newer versions of Consul are released, the minimum version of Envoy
it supports as a sidecar proxy also gets bumped. Starting with the upcoming
Consul v1.9.X series, Envoy v1.11.X will no longer be supported. Current
versions of Nomad hardcode a version of Envoy v1.11.2 to be used as the
default implementation of Connect sidecar proxy.

This PR introduces a change such that each Nomad Client will query its
local Consul for a list of Envoy proxies that it supports (hashicorp/consul#8545)
and then launch the Connect sidecar proxy task using the latest supported version
of Envoy. If the API component is not available, Nomad will fallback to
the old version of Envoy supported by old versions of Consul.

Setting the meta configuration option `meta.connect.sidecar_image` or
setting the `connect.sidecar_task` stanza will take precedence as is
the current behavior.

Addresses #8585 #7665
shoenig added a commit that referenced this issue Sep 22, 2020
@shoenig
consul/connect: dynamically select envoy sidecar at runtime
cc34fff 
As newer versions of Consul are released, the minimum version of Envoy
it supports as a sidecar proxy also gets bumped. Starting with the upcoming
Consul v1.9.X series, Envoy v1.11.X will no longer be supported. Current
versions of Nomad hardcode a version of Envoy v1.11.2 to be used as the
default implementation of Connect sidecar proxy.

This PR introduces a change such that each Nomad Client will query its
local Consul for a list of Envoy proxies that it supports (hashicorp/consul#8545)
and then launch the Connect sidecar proxy task using the latest supported version
of Envoy. If the `SupportedProxies` API component is not available from
Consul, Nomad will fallback to the old version of Envoy supported by old
versions of Consul.

Setting the meta configuration option `meta.connect.sidecar_image` or
setting the `connect.sidecar_task` stanza will take precedence as is
the current behavior for sidecar proxies.

Setting the meta configuration option `meta.connect.gateway_image`
will take precedence as is the current behavior for connect gateways.

`meta.connect.sidecar_image` and `meta.connect.gateway_image` may make
use of the special `${NOMAD_envoy_version}` variable interpolation, which
resolves to the newest version of Envoy supported by the Consul agent.

Addresses #8585 #7665
@shoenig shoenig mentioned this issue Sep 22, 2020
Merged
shoenig added a commit that referenced this issue Oct 13, 2020
@shoenig
consul/connect: dynamically select envoy sidecar at runtime
bdeb73c 
As newer versions of Consul are released, the minimum version of Envoy
it supports as a sidecar proxy also gets bumped. Starting with the upcoming
Consul v1.9.X series, Envoy v1.11.X will no longer be supported. Current
versions of Nomad hardcode a version of Envoy v1.11.2 to be used as the
default implementation of Connect sidecar proxy.

This PR introduces a change such that each Nomad Client will query its
local Consul for a list of Envoy proxies that it supports (hashicorp/consul#8545)
and then launch the Connect sidecar proxy task using the latest supported version
of Envoy. If the `SupportedProxies` API component is not available from
Consul, Nomad will fallback to the old version of Envoy supported by old
versions of Consul.

Setting the meta configuration option `meta.connect.sidecar_image` or
setting the `connect.sidecar_task` stanza will take precedence as is
the current behavior for sidecar proxies.

Setting the meta configuration option `meta.connect.gateway_image`
will take precedence as is the current behavior for connect gateways.

`meta.connect.sidecar_image` and `meta.connect.gateway_image` may make
use of the special `${NOMAD_envoy_version}` variable interpolation, which
resolves to the newest version of Envoy supported by the Consul agent.

Addresses #8585 #7665
@shoenig
Copy link
Contributor

shoenig commented Oct 13, 2020

Addressed by #8945

@shoenig shoenig closed this as completed Oct 13, 2020
fredrikhgrelland pushed a commit to fredrikhgrelland/nomad that referenced this issue Oct 22, 2020
@shoenig @fredrikhgrelland
consul/connect: dynamically select envoy sidecar at runtime
5b51397 
As newer versions of Consul are released, the minimum version of Envoy
it supports as a sidecar proxy also gets bumped. Starting with the upcoming
Consul v1.9.X series, Envoy v1.11.X will no longer be supported. Current
versions of Nomad hardcode a version of Envoy v1.11.2 to be used as the
default implementation of Connect sidecar proxy.

This PR introduces a change such that each Nomad Client will query its
local Consul for a list of Envoy proxies that it supports (hashicorp/consul#8545)
and then launch the Connect sidecar proxy task using the latest supported version
of Envoy. If the `SupportedProxies` API component is not available from
Consul, Nomad will fallback to the old version of Envoy supported by old
versions of Consul.

Setting the meta configuration option `meta.connect.sidecar_image` or
setting the `connect.sidecar_task` stanza will take precedence as is
the current behavior for sidecar proxies.

Setting the meta configuration option `meta.connect.gateway_image`
will take precedence as is the current behavior for connect gateways.

`meta.connect.sidecar_image` and `meta.connect.gateway_image` may make
use of the special `${NOMAD_envoy_version}` variable interpolation, which
resolves to the newest version of Envoy supported by the Consul agent.

Addresses hashicorp#8585 hashicorp#7665
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shoenig shoenig

Labels
theme/consul/connect Consul Connect integration type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hanshasselberg @shoenig @jrasell