Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unmarshaling of interface attribute #11

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

omarismail
Copy link

Description

The current package does not have the ability to unmarshal directly into an interface. This enables that functionality.

@omarismail omarismail requested review from a team and chrisarcand August 16, 2021 20:20
Copy link
Member

@chrisarcand chrisarcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit!

Copy link
Member

@thrashr888 thrashr888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have another PR this might help with 👍🏻

@omarismail omarismail merged commit 15d5181 into master Aug 17, 2021
@omarismail omarismail deleted the omarismail/interface-attr branch August 17, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants