-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Add support for labels & annotations to AgentDeployment #494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve left some comments, and a few things were missed:
-
We should add basic validations for annotations and labels. At least, we need to make sure their keys and values are not empty. If we don't, it could cause problems with the deployment and make it harder to find.
-
Don’t forget to update the Agent Pool CRD.
-
Change logs! :)
Let me know if you want to make this change with multiple PRs or one. For now, it looks like one PR for all changes, however, it is unfinished.
Here is how annotations and labels are validated in Kubernetes: |
1575aa2
to
d06cd5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for this change! 🚀
Description
This PR allows configuring annotations and labels for the agent pods deployed by the AgentPool controller.
Usage Example
References
Community Note