Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀Add Configurable RBAC Support #491

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

domino-sbr1
Copy link
Contributor

@domino-sbr1 domino-sbr1 commented Sep 23, 2024

Description

This pull request introduces configurable Role-Based Access Control (RBAC) support to the HCP Terraform Operator.
The following changes have been made:

  • Helm Chart Updates:
    • Added Helm chart value to values.yaml file to enable or disable the creation of RBAC resources.
    • Modified the Helm templates to conditionally create RBAC resources based on the provided value.

Motivation

The addition of configurable RBAC support allows users to have more control over the security and permissions of the HCP Terraform Operator. This is particularly useful for environments with strict security requirements or custom RBAC policies.

Usage Example

To enable/disable RBAC creation, set the rbac.create value to true or false in your values.yaml file:

rbac:
  create: true

References

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@domino-sbr1 domino-sbr1 requested a review from a team as a code owner September 23, 2024 18:39
Copy link

hashicorp-cla-app bot commented Sep 23, 2024

CLA assistant check
All committers have signed the CLA.

@domino-sbr1 domino-sbr1 changed the title Add Configurable RBAC Support 🚀Add Configurable RBAC Support Sep 23, 2024
@domino-sbr1 domino-sbr1 force-pushed the feature/configurable-rbac branch 2 times, most recently from 7022fd9 to 7fdb7c1 Compare September 27, 2024 13:00
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @domino-sbr1,

All in all, looks great! I have left a few minor comments to address.

Please add a change log entry, we use changie:

$ changie new --kind ENHANCEMENTS --custom "PR=491" --body '`Helm Chart`: Add the ability to configure the creation of the RBAC role and role binding.'

Thanks!

@domino-sbr1 domino-sbr1 force-pushed the feature/configurable-rbac branch from 7fdb7c1 to 5971e87 Compare September 30, 2024 20:52
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 30, 2024
@domino-sbr1 domino-sbr1 force-pushed the feature/configurable-rbac branch from 5971e87 to a8e1cbc Compare October 2, 2024 14:34
@domino-sbr1 domino-sbr1 force-pushed the feature/configurable-rbac branch from a8e1cbc to b090994 Compare October 7, 2024 13:05
@domino-sbr1
Copy link
Contributor Author

domino-sbr1 commented Oct 7, 2024

Hi @domino-sbr1,

All in all, looks great! I have left a few minor comments to address.

Please add a change log entry, we use changie:

$ changie new --kind ENHANCEMENTS --custom "PR=491" --body '`Helm Chart`: Add the ability to configure the creation of the RBAC role and role binding.'

Thanks!

Hi @arybolovlev, it's already done, I added new log entry

Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @domino-sbr1!

Thank you for this improvement! All looks good! 🚀

@arybolovlev arybolovlev merged commit 0922392 into hashicorp:main Oct 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm-chart size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: Configurable RBAC for Terraform Cloud Operator
2 participants